This repository has been archived by the owner on Nov 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
Change the openat macro to use the syscall intrinsic for 4 argument syscalls #141
Open
mjz19910
wants to merge
165
commits into
tsoding:master
Choose a base branch
from
mjz19910:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 13, 2021
-
Revert "The development is moved to GitLab"
This reverts commit 5b38fb3.
Configuration menu - View commit details
-
Copy full SHA for 96efeda - Browse repository at this point
Copy the full SHA 96efedaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fdbb05 - Browse repository at this point
Copy the full SHA 8fdbb05View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1073f1 - Browse repository at this point
Copy the full SHA f1073f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8cda8e - Browse repository at this point
Copy the full SHA a8cda8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12e9a58 - Browse repository at this point
Copy the full SHA 12e9a58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bde7e9 - Browse repository at this point
Copy the full SHA 1bde7e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4be390 - Browse repository at this point
Copy the full SHA e4be390View commit details -
Configuration menu - View commit details
-
Copy full SHA for 595f213 - Browse repository at this point
Copy the full SHA 595f213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d62337 - Browse repository at this point
Copy the full SHA 4d62337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 234f336 - Browse repository at this point
Copy the full SHA 234f336View commit details
Commits on Oct 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for eb7f2db - Browse repository at this point
Copy the full SHA eb7f2dbView commit details -
Implement a better Type Checking strategy
The strategy is based on check all of the possible execution paths
Configuration menu - View commit details
-
Copy full SHA for 7559ca1 - Browse repository at this point
Copy the full SHA 7559ca1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce0e2b1 - Browse repository at this point
Copy the full SHA ce0e2b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f46a35c - Browse repository at this point
Copy the full SHA f46a35cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7df1ef - Browse repository at this point
Copy the full SHA e7df1efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f61b6a - Browse repository at this point
Copy the full SHA 8f61b6aView commit details
Commits on Oct 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 30597e0 - Browse repository at this point
Copy the full SHA 30597e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a993f1 - Browse repository at this point
Copy the full SHA 1a993f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e15628 - Browse repository at this point
Copy the full SHA 2e15628View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb96f71 - Browse repository at this point
Copy the full SHA cb96f71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5abd5dc - Browse repository at this point
Copy the full SHA 5abd5dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a2c804 - Browse repository at this point
Copy the full SHA 5a2c804View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed0e54d - Browse repository at this point
Copy the full SHA ed0e54dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f271d14 - Browse repository at this point
Copy the full SHA f271d14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cebbf0 - Browse repository at this point
Copy the full SHA 2cebbf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b7293 - Browse repository at this point
Copy the full SHA f4b7293View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53e935f - Browse repository at this point
Copy the full SHA 53e935fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23d390c - Browse repository at this point
Copy the full SHA 23d390cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b94b00 - Browse repository at this point
Copy the full SHA 0b94b00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b71215 - Browse repository at this point
Copy the full SHA 8b71215View commit details -
Configuration menu - View commit details
-
Copy full SHA for 178b37c - Browse repository at this point
Copy the full SHA 178b37cView commit details
Commits on Oct 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 324e3b3 - Browse repository at this point
Copy the full SHA 324e3b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30e94ee - Browse repository at this point
Copy the full SHA 30e94eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f1e258 - Browse repository at this point
Copy the full SHA 1f1e258View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8627c5 - Browse repository at this point
Copy the full SHA d8627c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 955189a - Browse repository at this point
Copy the full SHA 955189aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 277e8dd - Browse repository at this point
Copy the full SHA 277e8ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9304758 - Browse repository at this point
Copy the full SHA 9304758View commit details -
Configuration menu - View commit details
-
Copy full SHA for b19df02 - Browse repository at this point
Copy the full SHA b19df02View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7fa572 - Browse repository at this point
Copy the full SHA d7fa572View commit details -
Configuration menu - View commit details
-
Copy full SHA for eedccc6 - Browse repository at this point
Copy the full SHA eedccc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for af6e6ab - Browse repository at this point
Copy the full SHA af6e6abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76101cc - Browse repository at this point
Copy the full SHA 76101ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for d120972 - Browse repository at this point
Copy the full SHA d120972View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3619e2d - Browse repository at this point
Copy the full SHA 3619e2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4e433d - Browse repository at this point
Copy the full SHA c4e433dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11ce39e - Browse repository at this point
Copy the full SHA 11ce39eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6288a7 - Browse repository at this point
Copy the full SHA c6288a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1690251 - Browse repository at this point
Copy the full SHA 1690251View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77aa504 - Browse repository at this point
Copy the full SHA 77aa504View commit details
Commits on Oct 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7616e8b - Browse repository at this point
Copy the full SHA 7616e8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c39744b - Browse repository at this point
Copy the full SHA c39744bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ba3bc1 - Browse repository at this point
Copy the full SHA 9ba3bc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e540914 - Browse repository at this point
Copy the full SHA e540914View commit details -
Configuration menu - View commit details
-
Copy full SHA for 233ab17 - Browse repository at this point
Copy the full SHA 233ab17View commit details -
Configuration menu - View commit details
-
Copy full SHA for d02b7d6 - Browse repository at this point
Copy the full SHA d02b7d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9390b9e - Browse repository at this point
Copy the full SHA 9390b9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f15600 - Browse repository at this point
Copy the full SHA 4f15600View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4e5f4c - Browse repository at this point
Copy the full SHA c4e5f4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f4b0be - Browse repository at this point
Copy the full SHA 9f4b0beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12cf637 - Browse repository at this point
Copy the full SHA 12cf637View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae0d740 - Browse repository at this point
Copy the full SHA ae0d740View commit details
Commits on Oct 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 05d7895 - Browse repository at this point
Copy the full SHA 05d7895View commit details -
Configuration menu - View commit details
-
Copy full SHA for e83bb4f - Browse repository at this point
Copy the full SHA e83bb4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d83a23 - Browse repository at this point
Copy the full SHA 6d83a23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1df87d0 - Browse repository at this point
Copy the full SHA 1df87d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d68f14 - Browse repository at this point
Copy the full SHA 6d68f14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35f0390 - Browse repository at this point
Copy the full SHA 35f0390View commit details -
Configuration menu - View commit details
-
Copy full SHA for 847ed04 - Browse repository at this point
Copy the full SHA 847ed04View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef87796 - Browse repository at this point
Copy the full SHA ef87796View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5511d3 - Browse repository at this point
Copy the full SHA f5511d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10d4d15 - Browse repository at this point
Copy the full SHA 10d4d15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 844acdf - Browse repository at this point
Copy the full SHA 844acdfView commit details
Commits on Oct 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 85273a3 - Browse repository at this point
Copy the full SHA 85273a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94921cf - Browse repository at this point
Copy the full SHA 94921cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67e06a5 - Browse repository at this point
Copy the full SHA 67e06a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b16e56 - Browse repository at this point
Copy the full SHA 9b16e56View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff42c7f - Browse repository at this point
Copy the full SHA ff42c7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d39e8b4 - Browse repository at this point
Copy the full SHA d39e8b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dc2c48 - Browse repository at this point
Copy the full SHA 6dc2c48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14713bc - Browse repository at this point
Copy the full SHA 14713bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 828243d - Browse repository at this point
Copy the full SHA 828243dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc06f09 - Browse repository at this point
Copy the full SHA cc06f09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1815842 - Browse repository at this point
Copy the full SHA 1815842View commit details -
Configuration menu - View commit details
-
Copy full SHA for 298a316 - Browse repository at this point
Copy the full SHA 298a316View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c510a8 - Browse repository at this point
Copy the full SHA 9c510a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bdd26a - Browse repository at this point
Copy the full SHA 0bdd26aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 400c21a - Browse repository at this point
Copy the full SHA 400c21aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab1c464 - Browse repository at this point
Copy the full SHA ab1c464View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4f7053 - Browse repository at this point
Copy the full SHA c4f7053View commit details -
I don't think it matters that much. After Porth is rewritten in itself simulation is going to be pretty trivial
Configuration menu - View commit details
-
Copy full SHA for 7be8b3b - Browse repository at this point
Copy the full SHA 7be8b3bView commit details -
I don't think it matters that much. Parsing is far from slowest part of the compilation process.
Configuration menu - View commit details
-
Copy full SHA for 177b006 - Browse repository at this point
Copy the full SHA 177b006View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca2f74f - Browse repository at this point
Copy the full SHA ca2f74fView commit details
Commits on Oct 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 47329a1 - Browse repository at this point
Copy the full SHA 47329a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 488fc9c - Browse repository at this point
Copy the full SHA 488fc9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 321c007 - Browse repository at this point
Copy the full SHA 321c007View commit details -
Configuration menu - View commit details
-
Copy full SHA for 324eddb - Browse repository at this point
Copy the full SHA 324eddbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6916d2 - Browse repository at this point
Copy the full SHA b6916d2View commit details
Commits on Oct 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f4c9d01 - Browse repository at this point
Copy the full SHA f4c9d01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9279f4f - Browse repository at this point
Copy the full SHA 9279f4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 978f3a2 - Browse repository at this point
Copy the full SHA 978f3a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34b3d70 - Browse repository at this point
Copy the full SHA 34b3d70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 997dcfd - Browse repository at this point
Copy the full SHA 997dcfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f772df - Browse repository at this point
Copy the full SHA 1f772dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02d37ab - Browse repository at this point
Copy the full SHA 02d37abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12ba823 - Browse repository at this point
Copy the full SHA 12ba823View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3218640 - Browse repository at this point
Copy the full SHA 3218640View commit details -
Configuration menu - View commit details
-
Copy full SHA for afa1e7e - Browse repository at this point
Copy the full SHA afa1e7eView commit details -
The chain of else if-s is done like this now: ```porth ... if ... orelse ... if ... orelse ... if ... orelse ... if ... else ... end ```
Configuration menu - View commit details
-
Copy full SHA for cfe0f7c - Browse repository at this point
Copy the full SHA cfe0f7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf25d36 - Browse repository at this point
Copy the full SHA cf25d36View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf29e5a - Browse repository at this point
Copy the full SHA bf29e5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7fdd95 - Browse repository at this point
Copy the full SHA d7fdd95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9161bf8 - Browse repository at this point
Copy the full SHA 9161bf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63b993f - Browse repository at this point
Copy the full SHA 63b993fView commit details
Commits on Oct 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4e3b7b6 - Browse repository at this point
Copy the full SHA 4e3b7b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 048c9fa - Browse repository at this point
Copy the full SHA 048c9faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 712fdfd - Browse repository at this point
Copy the full SHA 712fdfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a264b3 - Browse repository at this point
Copy the full SHA 1a264b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7434dc7 - Browse repository at this point
Copy the full SHA 7434dc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3949a5b - Browse repository at this point
Copy the full SHA 3949a5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb154d0 - Browse repository at this point
Copy the full SHA cb154d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddcb7ca - Browse repository at this point
Copy the full SHA ddcb7caView commit details
Commits on Oct 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3453a77 - Browse repository at this point
Copy the full SHA 3453a77View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd2ecac - Browse repository at this point
Copy the full SHA dd2ecacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d9c095 - Browse repository at this point
Copy the full SHA 0d9c095View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cb7cda - Browse repository at this point
Copy the full SHA 8cb7cdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecfb063 - Browse repository at this point
Copy the full SHA ecfb063View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14c2dce - Browse repository at this point
Copy the full SHA 14c2dceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20f6084 - Browse repository at this point
Copy the full SHA 20f6084View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4efd17 - Browse repository at this point
Copy the full SHA a4efd17View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab6dcff - Browse repository at this point
Copy the full SHA ab6dcffView commit details -
Configuration menu - View commit details
-
Copy full SHA for efd5343 - Browse repository at this point
Copy the full SHA efd5343View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d297c1 - Browse repository at this point
Copy the full SHA 7d297c1View commit details
Commits on Oct 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 149c9be - Browse repository at this point
Copy the full SHA 149c9beView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7ac452 - Browse repository at this point
Copy the full SHA e7ac452View commit details -
Configuration menu - View commit details
-
Copy full SHA for babb630 - Browse repository at this point
Copy the full SHA babb630View commit details -
Configuration menu - View commit details
-
Copy full SHA for cde20ef - Browse repository at this point
Copy the full SHA cde20efView commit details -
Configuration menu - View commit details
-
Copy full SHA for e05bb15 - Browse repository at this point
Copy the full SHA e05bb15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7384a5b - Browse repository at this point
Copy the full SHA 7384a5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2132747 - Browse repository at this point
Copy the full SHA 2132747View commit details -
Configuration menu - View commit details
-
Copy full SHA for c448252 - Browse repository at this point
Copy the full SHA c448252View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb86a6c - Browse repository at this point
Copy the full SHA eb86a6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e2d154 - Browse repository at this point
Copy the full SHA 8e2d154View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11603fa - Browse repository at this point
Copy the full SHA 11603faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52bd8da - Browse repository at this point
Copy the full SHA 52bd8daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a7b869 - Browse repository at this point
Copy the full SHA 8a7b869View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9bb98d - Browse repository at this point
Copy the full SHA b9bb98dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36f3b06 - Browse repository at this point
Copy the full SHA 36f3b06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fd75e9 - Browse repository at this point
Copy the full SHA 8fd75e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56b4731 - Browse repository at this point
Copy the full SHA 56b4731View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9303aa3 - Browse repository at this point
Copy the full SHA 9303aa3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cffb0a - Browse repository at this point
Copy the full SHA 0cffb0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09de628 - Browse repository at this point
Copy the full SHA 09de628View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f23650 - Browse repository at this point
Copy the full SHA 9f23650View commit details
Commits on Oct 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 71b1c5b - Browse repository at this point
Copy the full SHA 71b1c5bView commit details -
Change the openat syscall so it takes 4 arguments
Change the syscall intrinsic the openat macro uses to the 4 argument syscall intrinsic. When I was refactoring the porth.porth program to actually write output to a file, I encountered the inability to set the permission mask when `openat`ing the out.asm file.
Configuration menu - View commit details
-
Copy full SHA for e8d057c - Browse repository at this point
Copy the full SHA e8d057cView commit details -
Some porth programming, get porth to fork and run
a different program. Stuff I already did... Porth, open and write the asm to a file. Stuff I will work on... Python, want to figure out constant folding optimization next
Configuration menu - View commit details
-
Copy full SHA for 0b0d184 - Browse repository at this point
Copy the full SHA 0b0d184View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6edf33 - Browse repository at this point
Copy the full SHA e6edf33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c195da - Browse repository at this point
Copy the full SHA 6c195daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 618e7e0 - Browse repository at this point
Copy the full SHA 618e7e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ee34dc - Browse repository at this point
Copy the full SHA 1ee34dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad51df3 - Browse repository at this point
Copy the full SHA ad51df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d0f1d7 - Browse repository at this point
Copy the full SHA 1d0f1d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 157023f - Browse repository at this point
Copy the full SHA 157023fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 190d7c2 - Browse repository at this point
Copy the full SHA 190d7c2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.