Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CI into 2 jobs. #154

Merged
merged 12 commits into from
Mar 1, 2024
Merged

Split CI into 2 jobs. #154

merged 12 commits into from
Mar 1, 2024

Conversation

tspascoal
Copy link
Owner

@tspascoal tspascoal commented Mar 1, 2024

This pull request primarily modifies the GitHub Actions workflow file .github/workflows/ci.yml. The changes involve restructuring the workflow by removing the CodeQL analysis from the main job and creating a separate job for it. The new job, named code-scan, is responsible for the CodeQL analysis and has its own permissions and steps. The removed steps from the main job include the initialization of CodeQL and the performance of CodeQL analysis.

Here are the main changes:

  • Removed security-events: write permission from the main job.
  • Removed the initialization of CodeQL and related configurations from the main job.
  • Removed the CodeQL analysis step from the main job.
  • Added a new job code-scan with permissions contents: read, checks: write, and security-events: write. This job includes steps for checking out the code, setting up DotNet, initializing CodeQL, restoring dependencies, building the project, and performing the CodeQL analysis.

Downgrades coverlet to 6.0.0 to workaround bug coverlet-coverage/coverlet#1625

One for build and test and another for codescanning
Copy link

github-actions bot commented Mar 1, 2024

Tests Results

117 tests  ±0   117 ✅ ±0   7s ⏱️ ±0s
  3 suites ±0     0 💤 ±0 
  3 files   ±0     0 ❌ ±0 

Results for commit 5dfd893. ± Comparison against base commit 9f22cf0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 1, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
GitHubActions.Gates.Framework 55% 44% 319
Issues.Gate 79% 87% 160
DeployHours.Gate 95% 95% 73
Summary 64% (753 / 1168) 63% (290 / 462) 552

Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tspascoal tspascoal merged commit d1956b1 into main Mar 1, 2024
5 checks passed
@tspascoal tspascoal deleted the split-ci-jobs branch March 1, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant