fix(projectors): correct implementation of sample in Scale and Shift

tspooner · May 4, 2018 · e324244 · e324244
1 parent b5f8481
commit e324244
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/projectors/mixing/scaling.rs b/src/projectors/mixing/scaling.rs
@@ -25,7 +25,7 @@ impl<I: ?Sized, P: Projector<I>> Space for Scale<I, P> {
     type Value = Projection;
 
     fn sample(&self, rng: &mut ThreadRng) -> Projection {
-        self.projector.sample(rng)
+        Projection::Dense(self.projector.sample(rng).expanded(self.dim()) * self.scale)
     }
 
     fn dim(&self) -> usize {

diff --git a/src/projectors/mixing/shifting.rs b/src/projectors/mixing/shifting.rs
@@ -25,7 +25,7 @@ impl<I: ?Sized, P: Projector<I>> Space for Shift<I, P> {
     type Value = Projection;
 
     fn sample(&self, rng: &mut ThreadRng) -> Projection {
-        self.projector.sample(rng)
+        Projection::Dense(self.projector.sample(rng).expanded(self.dim()) + self.offset)
     }
 
     fn dim(&self) -> usize {