Improve and robustify normalisation #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new submodule, norms, to the geometry module with the following utility functions for computing the: - l1 (Taxicab/Manhattan) norm, - l2 (Euclidean) norm, - general lp norm, - max (infinity/uniform/supremum) norm.
As in other implementations dotted across the web, we now scale the coefficients using the l2-norm and filter for duplicates. An l1-norm is then applied to the final feature vector to ensure sum(phi) = 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus far the projection structs each coded their own implementation of the various normalisation schemes such as l1 or l2 norm. With this PR we include a new
geometry::normsmodule which includes some methods for computing normalisation constants.In addition, the projection structs have been refactored to use these new methods and their tests updated accordingly.