This repository has been archived by the owner on Jun 23, 2020. It is now read-only.
Register RaiseError Middleware Under Non-Conflicting Name #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gem includes a the DeskApi::Response::RaiseError middleware, which was registered as :raise_error. However, there is already a built-in middleware from Faraday that is registered under this same name. This causes the built-in middleware to be silently replaced by desk's, which I have observed to break other clients that need to use :raise_error with Faraday.
To fix this, I have changed the registered name of the middleware to :raise_desk_api.