Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ssh keys are created when the tests are not run #1040

Closed
bowlofeggs opened this issue Sep 3, 2022 · 0 comments · Fixed by #1041
Closed

Test ssh keys are created when the tests are not run #1040

bowlofeggs opened this issue Sep 3, 2022 · 0 comments · Fixed by #1041
Labels

Comments

@bowlofeggs
Copy link
Contributor

lnav version
v0.11.0

Describe the bug
Even if the tests are not run, this output appears during the build:

Making all in test
make[1]: Entering directory '/var/tmp/portage/app-admin/lnav-0.10.0-r1/work/lnav-0.10.0/test'
x86_64-pc-linux-gnu-g++ -std=c++14 -DHAVE_CONFIG_H -I. -I../src  -Wall -I../src -I../src/fmtlib     -D_ISOC99_SOURCE -D__STDC_LIMIT_MACROS -D_GNU_SOURCE  -O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -c -o test_stubs.o test_stubs.cc
mkdir -p remote
mkdir -p remote
mkdir -p remote
ssh-keygen -f remote/ssh_host_dsa_key -N '' -t dsa
ssh-keygen -f remote/ssh_host_rsa_key -N '' -t rsa
ssh-keygen -f remote/id_rsa -N '' -t rsa
Generating public/private dsa key pair.
Generating public/private rsa key pair.
Generating public/private rsa key pair.
Your identification has been saved in remote/ssh_host_dsa_key
Your public key has been saved in remote/ssh_host_dsa_key.pub
The key fingerprint is:
SHA256:NQvzaxZIgcvWhve2SEvLa66/iybF6001pXqjF8sCFTY portage@localhost
The key's randomart image is:
+---[DSA 1024]----+
|       ..        |
|      . E.       |
|     . =+oo .    |
|      =.=* =     |
|     o +S.B      |
|      + oo++     |
|     . *o**+     |
|    . o+B==.     |
|     ++=O*       |
+----[SHA256]-----+
Your identification has been saved in remote/ssh_host_rsa_key
Your public key has been saved in remote/ssh_host_rsa_key.pub
The key fingerprint is:
SHA256:ZEubpJvyTMRUYm1w7lxr4k5ORRLnX4Mx06tkB8LdEdo portage@localhost
The key's randomart image is:
+---[RSA 3072]----+
|      +o+...+ooo |
|     . =o+o oBo  |
|      ..B +.o.E. |
|     o O B oo.o. |
|      + S +o.o   |
|     . + +  .    |
|    . + +        |
|     = =         |
|      o o        |
+----[SHA256]-----+
Your identification has been saved in remote/id_rsa
Your public key has been saved in remote/id_rsa.pub
The key fingerprint is:
SHA256:eQeFQjRU1tD2VSokuxW01/kP0duG2SBoynkGE2GDiuE portage@localhost
The key's randomart image is:
+---[RSA 3072]----+
|       =Xo=*=   o|
|  .   ...=.*+o +o|
| . o .  o.=.=.=oo|
|  E .  . B + +.*+|
|        S = . +.=|
|         + .   o.|
|                .|
|                 |
|                 |
+----[SHA256]-----+
cp -f remote/id_rsa.pub remote/authorized_keys
rm -f libtestdummy.a
x86_64-pc-linux-gnu-ar cru libtestdummy.a test_stubs.o
x86_64-pc-linux-gnu-ranlib libtestdummy.a
make[1]: Leaving directory '/var/tmp/portage/app-admin/lnav-0.10.0-r1/work/lnav-0.10.0/test'

To Reproduce
Steps to reproduce the behavior:

Make a build and watch the output.

See also: https://bugs.gentoo.org/813444

@bowlofeggs bowlofeggs added the bug label Sep 3, 2022
bowlofeggs added a commit to bowlofeggs/lnav that referenced this issue Sep 4, 2022
I believe the test/remote folder only needs to be setup for
test/test_remote.sh. Prior to this commit, it was being built during
make, rather than just during make check. This commit adjusts things so
that the test/remote folder is only generated during make check, and
only when test/test_remote.sh is being executed.

Fixes tstack#1040

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant