Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on arm64 #1154

Closed
bowlofeggs opened this issue May 5, 2023 · 1 comment
Closed

Tests fail on arm64 #1154

bowlofeggs opened this issue May 5, 2023 · 1 comment
Labels

Comments

@bowlofeggs
Copy link
Contributor

lnav version
v0.11.1

Describe the bug
A gentoo contributor filed a ticket describing a test failure on the arm64 architecture. You can download the full logs from the Gentoo ticket if you wish, but here's a sample from the output:

✘ error: invalid JSON
 --> {test_dir}/bad-config-json/formats/invalid-json/format.json:4
 | parse error: object key and value must be separated by a colon (':') 
 |           ar_log": {         "abc"     } }                          
 |                      (right here) ------^                           
 |                                                                     
⚠ warning: format file is missing “$schema” property
 --> {test_dir}/bad-config-json/formats/invalid-json/format.json
 =   note: the schema specifies the supported format version and can be used with editors to automatically validate the file
 =   help: add the following property to the top-level JSON object:
             "$schema": "https://lnav.org/schemas/format-v1.schema.json",
✘ error: “abc(” is not a valid regular expression
 reason: missing closing parenthesis
 --> /invalid_key_log/level-pointer
 | abc(                                    
 |     ^ missing closing parenthesis       
 --> {test_dir}/bad-config-json/formats/invalid-key/format.json:4
 |         "level-pointer": "abc(",        
 = help: Property Synopsis
           /invalid_key_log/level-pointer 
         Description
           A regular-expression that matches the JSON-pointer of the level property

To Reproduce
Run the tests on an arm64 system.

@bowlofeggs bowlofeggs added the bug label May 5, 2023
@tstack
Copy link
Owner

tstack commented May 24, 2023

One possible reason is that the NO_COLOR environment variable is set... do you happen to know if that's the case? Looking at the env dump in the build logs, it seems like that might be the case.

I've pushed a change to unset NO_COLOR in the the test environment.

tstack added a commit that referenced this issue May 24, 2023
@tstack tstack closed this as completed Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants