Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport patches from issue #42 #43

Closed
wants to merge 1 commit into from
Closed

Backport patches from issue #42 #43

wants to merge 1 commit into from

Commits on Apr 8, 2020

  1. [SimplifyCFG] Skip merging return blocks if it would break a CallBr. 

    SimplifyCFG should not merge empty return blocks and leave a CallBr behind
with a duplicated destination since the verifier will then trigger an
assert. This patch checks for this case and avoids the transformation.

CodeGenPrepare has a similar check which also has a FIXME comment about why
this is needed. It seems perhaps better if these two passes would eventually
instead update the CallBr instruction instead of just checking and avoiding.

This fixes https://bugs.llvm.org/show_bug.cgi?id=45062.

Review: Craig Topper

Differential Revision: https://reviews.llvm.org/D75620

(cherry picked from commit c2dafe1)
    @JonPsson @llvmbot
    JonPsson authored and llvmbot committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    327f41f View commit details
    Browse the repository at this point in the history