Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config, store): do not validated tags if the store failed to open #133

Merged
merged 2 commits into from Feb 24, 2024

Conversation

mrazauskas
Copy link
Member

If the store failed to open, the 'Supported tags..." message should be omitted. Currently it creates unnecessary noise.

@mrazauskas mrazauskas enabled auto-merge (squash) February 24, 2024 16:44
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c4fb3f5) 5272 5101 96.76%
Head commit (87aef72) 5272 (+0) 5101 (+0) 96.76% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#133) 3 2 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@mrazauskas mrazauskas merged commit 572c736 into main Feb 24, 2024
16 checks passed
@mrazauskas mrazauskas deleted the tag-validation-clean-up branch February 24, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant