-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(*): introduce Expect
class
#39
Merged
mrazauskas
merged 30 commits into
main
from
checker-emit-diagnostics-instead-of-throwing-errors
Dec 7, 2023
Merged
refactor(*): introduce Expect
class
#39
mrazauskas
merged 30 commits into
main
from
checker-emit-diagnostics-instead-of-throwing-errors
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 90.43% 90.86% +0.43%
==========================================
Files 83 88 +5
Lines 5392 5529 +137
Branches 750 739 -11
==========================================
+ Hits 4876 5024 +148
+ Misses 513 501 -12
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. |
mrazauskas
changed the title
refactor(checker): always report diagnostics instead of throwing errors
refactor(*): introduce Dec 5, 2023
Expect
class
mrazauskas
deleted the
checker-emit-diagnostics-instead-of-throwing-errors
branch
December 7, 2023 08:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the
Expect
class which does the following:"expect:error"
event instead of all throwing an error;this.typeChecker
, instead of optionaltypeChecker
currently provided by theAssertion
class;CollectService
class.Overall the structure and responsibilities will have a better shape.