Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #156

Merged
merged 5 commits into from
Mar 12, 2023
Merged

Dark mode #156

merged 5 commits into from
Mar 12, 2023

Conversation

andrewniekamp
Copy link
Contributor

@andrewniekamp andrewniekamp commented Mar 9, 2023

Included in this PR is a possible next step for the dark mode implementation, if it may be of use!

  • $CFG variable that can set a theme base color and dark mode flag
  • Launch parameters for 1.1 and 1.3 that will override the $CFG values
  • A new option in the profile menu, which overrides launch and $CFG values
  • Note: it is reflected in the store's Test page, but based on the logged in user profile, not any test user profiles

Between these dark mode changes and other general store and styling customizations, I ended up making a new stylesheet for tsugi-static. I'll plan to submit a PR for tsugi-static as well as another Tsugi PR for some styling updates to the store.

Please see below for the dark mode changes (with the tsugi-static changes).

image

image

@csev
Copy link
Collaborator

csev commented Mar 12, 2023

LGTM

@csev csev merged commit 6a2e028 into tsugiproject:master Mar 12, 2023
csev added a commit to tsugiproject/tsugi-php that referenced this pull request Mar 12, 2023
csev added a commit that referenced this pull request Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants