driver: ctrl_timeoutをモジュールパラメーターに追加 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending a request by `it930x_ctrl_msg()` sometimes fails due to the error code -110 (ETIMEDOUT). However, in some situations, the response seems to be received after the ETIMEDOUT error. This can be observed by capturing packets using `tcpdump` + `usbmon`. ```shell sudo modprobe usbmon sudo tcpdump -i usbmon<n> -s0 -U -w - | tee /path/to/capture.pcap | \ tcpdump -r - ``` Actually, no ETIMEDOUT error occur during timeshift recording with the following settings at least on my environment (ROCK64 + PX-W3U4): ```text options px4_drv ctrl_timeout=5000 psb_purge_timeout=5000 ``` These two timeout values are eventually passed to `usb_bulk_msg()`.
|
プルリクエストをありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
表題の通り，
ctrl_timeoutをモジュールパラメーターに追加する修正です．背景
Linux Kernel 6.xで以下のようなエラーをよく目にするようになりました．
ここで
-110はETIMEDOUTです．tcpdump+usbmonでusbでのやり取りを取得したところ，既定値の3000ms後に応答をちゃんと受信している場合があることが確認できました．遅延の原因はまだ不明ですが，それまでの対処療法としてctrl_timeoutをモジュールパラメーターに追加しました．以下を追加後，再起動．
ROCK64 + PX-W3U4上で動作しているmirakcによる４チャンネルのタイムシフト録画を行い４日経ちましたが，上記エラーは発生していません．
タイムアウト値は環境に依存するものと推測しますが，調整することによりエラーを回避できることが分かりました．
補足
usb_bulk_msgの詳細は https://manpages.debian.org/jessie-backports/linux-manual-4.8/usb_bulk_msg.9mirakcの
onair-program-trackers使用時に発生しているように見えることから，同一チューナーにて別チャンネルのストリームに短い時間間隔で切り替えると発生するのかもしれません．これは推測であり，詳細はまだ不明です．