display switch to space only when space is not active space #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eokoneyo
force-pushed
the
tsullivan-roles-spaces-modal
branch
from
e065a33
to
31635b7
Compare
tsullivan
reviewed
Jun 17, 2024
| render: (rowRecord: Space) => { | ||
| return ( | ||
| <EuiButtonIcon | ||
| href={getSpaceNavigationURL({ serverBasePath, spaceId: rowRecord.id })} |
There was a problem hiding this comment.
I imagined that the "switch" link would change the Space to the selected one without changing the navigation, but I think the way you have it works well also.
tsullivan
merged commit e844219
into
tsullivan:roles/details/spaces-modal
1 check passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary