Issue checkstyle#6123: ignore parameters of methods with modifiers no…

…t in 'memberModifiers'
tsunghanjacktsai · Dec 3, 2018 · 20dd9a9 · 20dd9a9
1 parent e91a353
commit 20dd9a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheck.java
@@ -297,7 +297,8 @@ private void visitParameterDef(DetailAST parameterDef) {
         final DetailAST grandParentAST = parameterDef.getParent().getParent();
 
         if (grandParentAST.getType() == TokenTypes.METHOD_DEF
-            && isCheckedMethod(grandParentAST)) {
+            && isCheckedMethod(grandParentAST)
+            && isVerifiable(grandParentAST)) {
             checkClassName(parameterDef);
         }
     }

diff --git a/...uppycrawl/tools/checkstyle/checks/coding/illegaltype/InputIllegalTypeMemberModifiers.java b/...uppycrawl/tools/checkstyle/checks/coding/illegaltype/InputIllegalTypeMemberModifiers.java
@@ -32,4 +32,7 @@ private class Some {
     //WARNING if memberModifiers is set and contains TokenTypes.LITERAL_PROTECTED
     protected AbstractClass a1 = null;
     public AbstractClass a2 = null;
+
+    //NO WARNING if memberModifiers is set and does not contain TokenTypes.LITERAL_PUBLIC
+    public void table5(java.util.TreeSet<Object> arg) { }
 }