This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Get log for a project #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review my patch! ;-) |
| func GetLog(w http.ResponseWriter, r *http.Request) { | ||
| repo := r.URL.Query().Get(":name") | ||
| ref := r.URL.Query().Get("ref") | ||
| total, _ := strconv.Atoi(r.URL.Query().Get("total")) |
There was a problem hiding this comment.
Why you are ignoring this error. What will happens if total can't be converted to int?
There was a problem hiding this comment.
total will be 0 and GetLog will return only one entry :-P
But yes, a bad request would be better.
|
@marcelometal sorry for the delay. See the comments above. |
| b, err := json.Marshal(logs) | ||
| if err != nil { | ||
| err := fmt.Errorf("Error when trying to obtain log for ref %s of repository %s (%s).", ref, repo, err) | ||
| http.Error(w, err.Error(), http.StatusBadRequest) |
There was a problem hiding this comment.
Should a json marshalling error be a bad request? I believe http.StatusInternalServerError fits better.
There was a problem hiding this comment.
So, I will send a patch to fix all others handlers.
Return git log for a given repository.
|
Done! Please review again ;-) |
|
LGTM @andrewsmedina feel free to merge it when you're good :) |
|
@marcelometal thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return git log for a given repository.