This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Support namespaces for repository #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return repositories, users, nil | ||
| } | ||
|
|
||
| func GrantAccess(w http.ResponseWriter, r *http.Request) { | ||
| func checkNamespaceRequirement(namespace string, hasNamespace bool) error { | ||
| if hasNamespace { |
There was a problem hiding this comment.
namespaceRequired is a better name.
| r, err := regexp.Compile(`git-([\w-]+) '/?([\w-]+)\.git'`) | ||
| // (git-[a-z-]+) '/?(([\w-+.@]+)/)?([\w-]+)\.git' | ||
| func parseGitCommand() (command, name string, err error) { | ||
| r, err := regexp.Compile(`(git-[a-z-]+) '/?([\w-+@][\w-+.@]*/)?([\w-]+)\.git'`) |
There was a problem hiding this comment.
You can simplify this regex removing the namespace group.
andrewsmedina
added a commit
that referenced
this pull request
Aug 26, 2014
Support namespaces for repository
|
@scorphus thank you! |
|
I'll comment on that regex as we agreed a bit earlier 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.