This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Changes of routes #160
Merged
Changes of routes #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @guilhermebruzzi, well spotted 👍 |
|
Maybe we should test the multiplexer instead of the handler. |
|
I'm +1 to test multiplexer. |
|
There are some handlers missing tests – entirely my bad – that's why this flaw is only identified by gandalf-client's tests. A soon-to-be-pulled-request will address this issue. Even though, I believe we could test the multiplexer, this was my initial intent. |
|
Please check #161 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the order of routes to correct a bug: when asked for /repository/name/branches|etc the regex of /repository/name matched first.