This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Improvements #162
Merged
Improvements #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -623,7 +623,7 @@ func (s *S) TestAddInvalidOldFormatHook(c *gocheck.C) { | |||
| c.Assert(recorder.Code, gocheck.Equals, 400) | |||
| } | |||
|
|
|||
| func (s *S) TestAddKeyShouldReturnErrorWhenUserDoesNotExists(c *gocheck.C) { | |||
| func (s *S) TestAddKeyShouldReturnErrorWhenUserDoesNotExist(c *gocheck.C) { // FIXED | |||
There was a problem hiding this comment.
why this FIXED comment?
There was a problem hiding this comment.
Oops. Good catch. My fault. Debris of various changes I was stashing since I started contributing to Gandalf. Let me clean and force push it…
There was a problem hiding this comment.
Thanks for pointing that out 😉
scorphus
force-pushed
the
improvements
branch
from
b2b2fb9
to
d89d96b
Compare
Also increase its coverage
scorphus
force-pushed
the
improvements
branch
from
d89d96b
to
92f7876
Compare
|
@scorphus thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More to come...