Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/tsuru: unify service-info and service-doc #1152

Closed
fsouza opened this issue Mar 26, 2015 · 3 comments
Closed

cmd/tsuru: unify service-info and service-doc #1152

fsouza opened this issue Mar 26, 2015 · 3 comments
Assignees

Comments

@fsouza
Copy link
Contributor

fsouza commented Mar 26, 2015

tsuru service-info could display the documentation of the service, if any is available.

@lucaspwbx
Copy link
Contributor

in this case we would need to display documentation for the service AND service-info right? Is there a better way to do this than returning the JSON representation of a map?
something like:

b, _ := json.Marshal(instances)
serviceMap := map[string][]byte{"doc": s.Doc, "info": b}
b2, _ := json.Marshal(serviceMap)
w.Write(b2)
return nil

@andrewsmedina
Copy link
Contributor

You can send the serialized "Service" and add a "Instances" attribute.

@lucaspwbx
Copy link
Contributor

good idea! thanx @andrewsmedina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants