Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding work for computing solid earth tides #186

Merged
merged 7 commits into from
Apr 8, 2023
Merged

feat: adding work for computing solid earth tides #186

merged 7 commits into from
Apr 8, 2023

Conversation

tsutterley
Copy link
Owner

feat: add SET correction program for files
feat: add function for phase angles
test: add SET checks vs IERS and IS2
fix: check if datetime before converting to seconds
fix: copy inputs in cartesian to not modify original arrays
docs: update documentation to denote SET

fix: remove "test" from model io
TODO: finish solid earth tide calculation following IERS conventions
TODO: update documentation denoting LPET and SET options
TODO: add validation testing for SET
feat: add function for phase angles
test: add IERS solid earth tests for each step
feat: add correction program for files
test: add SET checks vs IERS and IS2
fix: check if datetime before converting to seconds
fix: copy inputs in cartesian to not modify original arrays
docs: update documentation to denote SET
test: test geodetic conversion additionally as arrays
(if added when computing cartesian coordinates)
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage: 78.48% and project coverage change: +1.13 🎉

Comparison is base (fd5e7ff) 61.99% compared to head (f0a2437) 63.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   61.99%   63.12%   +1.13%     
==========================================
  Files          39       41       +2     
  Lines        7652     8128     +476     
  Branches      829      846      +17     
==========================================
+ Hits         4744     5131     +387     
- Misses       2596     2676      +80     
- Partials      312      321       +9     
Flag Coverage Δ
unittests 63.12% <78.48%> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyTMD/calc_astrol_longitudes.py 0.00% <0.00%> (-73.18%) ⬇️
pyTMD/io/GOT.py 64.75% <ø> (+0.97%) ⬆️
pyTMD/io/model.py 22.58% <0.00%> (-0.80%) ⬇️
test/test_ocean_pole_tide.py 100.00% <ø> (ø)
pyTMD/io/FES.py 45.66% <18.18%> (ø)
pyTMD/compute_tide_corrections.py 22.71% <35.00%> (+3.00%) ⬆️
pyTMD/spatial.py 71.12% <80.95%> (+0.21%) ⬆️
pyTMD/astro.py 89.52% <89.52%> (ø)
pyTMD/__init__.py 100.00% <100.00%> (ø)
pyTMD/load_nodal_corrections.py 98.75% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsutterley tsutterley merged commit 3063a53 into main Apr 8, 2023
3 of 4 checks passed
@tsutterley tsutterley deleted the dev branch April 9, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant