Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic file searching with glob strings in definition files for #183 #187

Merged
merged 9 commits into from
Apr 13, 2023

Conversation

tsutterley
Copy link
Owner

  • refactor: using pathlib to define and expand paths
  • feat: add parser for extracting constituents from filenames
  • feat: updated model definition read function for currents
  • feat: added iterative methods for converting from cartesian to geodetic
  • test: added model definition file tests
  • test: add geodetic conversion test

feat: updated model definition read function for currents
feat: added iterative methods for converting from cartesian to geodetic
test: added model definition file tests

test: add geodetic conversion test
feat: add parser for extracting constituents from filenames
fix: convert paths to str for octave inputs
fix: convert to str for octave open cases
fix: convert to str to print to definition files
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 74.95% and project coverage change: +3.99 🎉

Comparison is base (fd5e7ff) 61.99% compared to head (8f1460e) 65.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   61.99%   65.99%   +3.99%     
==========================================
  Files          39       42       +3     
  Lines        7652     8404     +752     
  Branches      829      944     +115     
==========================================
+ Hits         4744     5546     +802     
+ Misses       2596     2518      -78     
- Partials      312      340      +28     
Flag Coverage Δ
unittests 65.99% <74.95%> (+3.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyTMD/calc_astrol_longitudes.py 0.00% <0.00%> (-73.18%) ⬇️
pyTMD/io/ATLAS.py 41.24% <27.27%> (+0.46%) ⬆️
pyTMD/check_tide_points.py 65.15% <28.57%> (-1.52%) ⬇️
pyTMD/io/GOT.py 64.52% <30.00%> (+0.75%) ⬆️
pyTMD/io/OTIS.py 37.34% <35.00%> (+0.24%) ⬆️
pyTMD/io/FES.py 46.05% <35.29%> (+0.38%) ⬆️
pyTMD/compute_tide_corrections.py 22.48% <35.63%> (+2.76%) ⬆️
pyTMD/io/model.py 31.44% <44.96%> (+8.06%) ⬆️
pyTMD/time.py 68.96% <52.94%> (+1.30%) ⬆️
pyTMD/io/ocean_pole_tide.py 96.15% <66.66%> (+0.07%) ⬆️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs: add docstrings for solid earth sub-function inputs
docs: change _default_kernel to kwarg to prevent LONG description in rtd
@tsutterley tsutterley merged commit e313d60 into main Apr 13, 2023
4 checks passed
@tsutterley tsutterley deleted the dev branch April 13, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant