Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ignore note option #68

Merged
merged 5 commits into from
Mar 4, 2023
Merged

refactor: ignore note option #68

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db8b72a
refactor: ignore note option
tsuyoshicho Mar 4, 2023
f5eb967
efm opt using array
tsuyoshicho Mar 4, 2023
e7bac17
Revert "efm opt using array"
tsuyoshicho Mar 4, 2023
c1a3820
efm option using single quote
tsuyoshicho Mar 4, 2023
f2bfbbc
array retry
tsuyoshicho Mar 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 15 additions & 24 deletions script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,33 +41,24 @@ mypy_check_output="$(mypy --show-column-numbers \
"${INPUT_TARGET:-.}" 2>&1 \
)" || mypy_exit_val="$?"

IGNORE_NOTE_EFM_OPTION=()
if [[ "${INPUT_IGNORE_NOTE}" == "true" ]] ; then
# note ignore
# shellcheck disable=SC2086
echo "${mypy_check_output}" | reviewdog \
-efm="%-G%f:%l:%c: note: %m" \
-efm="%f:%l:%c: %t%*[^:]: %m" \
-efm="%f:%l: %t%*[^:]: %m" \
-efm="%f: %t%*[^:]: %m" \
-name="${INPUT_TOOL_NAME:-mypy}" \
-reporter="${INPUT_REPORTER:-github-pr-check}" \
-filter-mode="${INPUT_FILTER_MODE}" \
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
-level="${INPUT_LEVEL}" \
${INPUT_REVIEWDOG_FLAGS} || reviewdog_exit_val="$?"
else
# shellcheck disable=SC2086
echo "${mypy_check_output}" | reviewdog \
-efm="%f:%l:%c: %t%*[^:]: %m" \
-efm="%f:%l: %t%*[^:]: %m" \
-efm="%f: %t%*[^:]: %m" \
-name="${INPUT_TOOL_NAME:-mypy}" \
-reporter="${INPUT_REPORTER:-github-pr-check}" \
-filter-mode="${INPUT_FILTER_MODE}" \
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
-level="${INPUT_LEVEL}" \
${INPUT_REVIEWDOG_FLAGS} || reviewdog_exit_val="$?"
IGNORE_NOTE_EFM_OPTION=("-efm=%-G%f:%l:%c: note: %m")
fi

# shellcheck disable=SC2086
echo "${mypy_check_output}" | reviewdog \
"${IGNORE_NOTE_EFM_OPTION[@]}" \
-efm="%f:%l:%c: %t%*[^:]: %m" \
-efm="%f:%l: %t%*[^:]: %m" \
-efm="%f: %t%*[^:]: %m" \
-name="${INPUT_TOOL_NAME:-mypy}" \
-reporter="${INPUT_REPORTER:-github-pr-check}" \
-filter-mode="${INPUT_FILTER_MODE}" \
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
-level="${INPUT_LEVEL}" \
${INPUT_REVIEWDOG_FLAGS} || reviewdog_exit_val="$?"
echo '::endgroup::'

# Throw error if an error occurred and fail_on_error is true
Expand Down