feat: Add Support package manager(npm/yarn/pnpm) #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
後で確認します |
tsuyoshicho
requested changes
Oct 18, 2023
script.sh
Outdated
Comment on lines
27
to
28
| echo 'npm ci start' | ||
| npm ci |
There was a problem hiding this comment.
デフォルト値を持せるようになるわけなので、それ以外についてはエラーログを出してexit 1にすることにしましょうか
exit前に
echo '::endgroup::'
もわすれずにおねがいします。(なくても平気かもしれませんが)
tsuyoshicho
reviewed
Oct 18, 2023
tsuyoshicho
added
enhancement
tsuyoshicho
approved these changes
Oct 18, 2023
tsuyoshicho
changed the title
|
ありがとうございます、マージ&リリースします。 しました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request detail
Fix or Add/Remove in this PR/このプルリクエストでやったこと
package_managerオプションを設け、yarn と pnpm に対応しました。Pros and Cons/メリットとデメリット
メリット
The `npm ci` command can only install with an existing package-lock.json ...エラーが発生して止まってしまう状態だったが、このオプションにより問題なく textlint を使用できるようになった。デメリット
なし
Test/動作確認
Test item list up with checkbox, checked after tested./チェックボックス式にし、確認後チェックする。