added the ability to send data-parameters to requests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsv1
reviewed
Nov 21, 2017
jj/rule.py
Outdated
| @@ -3,11 +3,12 @@ | |||
|
|
|||
| class Rule: | |||
|
|
|||
| def __init__(self, method, route, params, headers): | |||
| def __init__(self, method, route, params, headers, data): | |||
There was a problem hiding this comment.
data - слишком много охватывает, лучше ограничить, т.к. для текущей задачи нужен только json
jj/rule.py
Outdated
| def match(self, request): | ||
| return self.__match_method(request.method) and \ | ||
| self.__match_route(request.path) and \ | ||
| self.__match_params(request.args) and \ | ||
| self.__match_headers(request.headers) | ||
| self.__match_headers(request.headers) and \ | ||
| self.__match_data(eval(request.data)) |
There was a problem hiding this comment.
eval - лучше не использовать
There was a problem hiding this comment.
payload = request.get_data(as_text=True)
if request.content_type == 'application/json':
json_payload = json.loads(payload)
Только нужно вынести в отдельный метод
updated data to json in mock.py
Nataliska
force-pushed
the
add-data-params-to-requests
branch
from
b9c492b
to
c2530a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.