Move exceptions into single module #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There also ClientException defined in pypump/client.py , i guess we could move that too? |
|
Good catch |
Current coverage is 74.18% (diff: 82.35%)@@ master #151 diff @@
==========================================
Files 19 14 -5
Lines 1242 1228 -14
Methods 0 0
Messages 0 0
Branches 204 204
==========================================
- Hits 913 911 -2
+ Misses 272 260 -12
Partials 57 57
|
|
Also, #147 conflicts with this branch, the import statement in feed_test.py needs modification when this PR is merged |
Also removes some unused exceptions Fixes #150
moggers87
force-pushed
the
150-exceptions
branch
from
95bb6e5
to
eec8313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes some unused exceptions
Fixes #150