Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests headers requires a str or bytes, and no longer accepts int #154

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Requests headers requires a str or bytes, and no longer accepts int #154

merged 1 commit into from
Jul 20, 2018

Conversation

craigmaloney
Copy link
Contributor

According to https://github.com/kennethreitz/requests/issues/3477 they no longer accept integers for the header parameter. Converting to string will resolve the issue.

This resolves tsyesika/p#42

@codecov-io
Copy link

Current coverage is 73.34% (diff: 100%)

Merging #154 into master will not change coverage

@@             master       #154   diff @@
==========================================
  Files            14         14          
  Lines          1242       1242          
  Methods           0          0          
  Messages          0          0          
  Branches        218        218          
==========================================
  Hits            911        911          
  Misses          274        274          
  Partials         57         57          

Powered by Codecov. Last update d0ae787...1873ae5

@moggers87
Copy link
Collaborator

Thanks!

I'm not merging this yet because I want to see if tests in master will fail or if we need to update our tests as well: https://travis-ci.org/xray7224/PyPump/builds/147601945

@phls
Copy link

phls commented Oct 20, 2016

Hi, any update?

Thanks,

@moggers87
Copy link
Collaborator

Our tests wouldn't have picked this change up, which is something I'd like to be fixed. This is probably due to mocking too much, but I've had no time to look into it.

@moggers87
Copy link
Collaborator

I'm going to go ahead and merge this. I've not tested it, but I don't see how it wouldn't just work™

We can always revert it later ;)

@moggers87 moggers87 merged commit f921f69 into tsyesika:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error to post image
4 participants