Skip to content

Commit

Permalink
feat: update landscape
Browse files Browse the repository at this point in the history
  • Loading branch information
tsypuk committed Jan 7, 2024
1 parent 2849514 commit 9f32c7f
Show file tree
Hide file tree
Showing 7 changed files with 89 additions and 8 deletions.
5 changes: 3 additions & 2 deletions docs/docs/onprem-components/docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ New (v0.3.19)

### Style:
```html
style="sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image=img/lib/mscae/Docker.svg;"
style="sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image=img/lib/mscae/Docker.svg;labelBackgroundColor=none;"
```

| attribute | value |
Expand All @@ -57,6 +57,7 @@ style="sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image
|html| 1 |
|image| |
|image| img/lib/mscae/Docker.svg |
|labelBackgroundColor| none |
|points| [] |
|sketch| 0 |

Expand All @@ -75,7 +76,7 @@ style="sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image
<root>
<mxCell id="0"/>
<mxCell id="1" parent="0"/>
<mxCell id="vertex:docker:arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123" value="&lt;b&gt;Name&lt;/b&gt;: docker&lt;BR&gt;&lt;b&gt;ID&lt;/b&gt;: arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;name&lt;/b&gt;: my-app&lt;BR&gt;&lt;b&gt;image&lt;/b&gt;: 123456789012.dkr.ecr.eu-west-1.amazonaws.com/cluster/myapp:v2-22-00&lt;BR&gt;&lt;b&gt;imageDigest&lt;/b&gt;: sha256:5562sfsf60a6d1aaed5c2bb227d3d4ec14c755bdb446349b&lt;BR&gt;&lt;b&gt;runtimeId&lt;/b&gt;: 56832234bec86b30201dbdc94-11149226&lt;BR&gt;&lt;b&gt;lastStatus&lt;/b&gt;: RUNNING&lt;BR&gt;&lt;b&gt;healthStatus&lt;/b&gt;: UNKNOWN&lt;BR&gt;&lt;b&gt;cpu&lt;/b&gt;: 512&lt;BR&gt;&lt;b&gt;memory&lt;/b&gt;: 1024" style="sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image=img/lib/mscae/Docker.svg;" parent="1" vertex="1">
<mxCell id="vertex:docker:arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123" value="&lt;b&gt;Name&lt;/b&gt;: docker&lt;BR&gt;&lt;b&gt;ID&lt;/b&gt;: arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;name&lt;/b&gt;: my-app&lt;BR&gt;&lt;b&gt;image&lt;/b&gt;: 123456789012.dkr.ecr.eu-west-1.amazonaws.com/cluster/myapp:v2-22-00&lt;BR&gt;&lt;b&gt;imageDigest&lt;/b&gt;: sha256:5562sfsf60a6d1aaed5c2bb227d3d4ec14c755bdb446349b&lt;BR&gt;&lt;b&gt;runtimeId&lt;/b&gt;: 56832234bec86b30201dbdc94-11149226&lt;BR&gt;&lt;b&gt;lastStatus&lt;/b&gt;: RUNNING&lt;BR&gt;&lt;b&gt;healthStatus&lt;/b&gt;: UNKNOWN&lt;BR&gt;&lt;b&gt;cpu&lt;/b&gt;: 512&lt;BR&gt;&lt;b&gt;memory&lt;/b&gt;: 1024" style="sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image=img/lib/mscae/Docker.svg;labelBackgroundColor=none;" parent="1" vertex="1">
<mxGeometry width="50" height="41" as="geometry"/>
</mxCell>
</root>
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/onprem-components/output/drawio/docker.drawio
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<root>
<mxCell id="0"/>
<mxCell id="1" parent="0"/>
<mxCell id="vertex:docker:arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123" value="&lt;b&gt;Name&lt;/b&gt;: docker&lt;BR&gt;&lt;b&gt;ID&lt;/b&gt;: arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;name&lt;/b&gt;: my-app&lt;BR&gt;&lt;b&gt;image&lt;/b&gt;: 123456789012.dkr.ecr.eu-west-1.amazonaws.com/cluster/myapp:v2-22-00&lt;BR&gt;&lt;b&gt;imageDigest&lt;/b&gt;: sha256:5562sfsf60a6d1aaed5c2bb227d3d4ec14c755bdb446349b&lt;BR&gt;&lt;b&gt;runtimeId&lt;/b&gt;: 56832234bec86b30201dbdc94-11149226&lt;BR&gt;&lt;b&gt;lastStatus&lt;/b&gt;: RUNNING&lt;BR&gt;&lt;b&gt;healthStatus&lt;/b&gt;: UNKNOWN&lt;BR&gt;&lt;b&gt;cpu&lt;/b&gt;: 512&lt;BR&gt;&lt;b&gt;memory&lt;/b&gt;: 1024" style="sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image=img/lib/mscae/Docker.svg;" parent="1" vertex="1">
<mxCell id="vertex:docker:arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123" value="&lt;b&gt;Name&lt;/b&gt;: docker&lt;BR&gt;&lt;b&gt;ID&lt;/b&gt;: arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;name&lt;/b&gt;: my-app&lt;BR&gt;&lt;b&gt;image&lt;/b&gt;: 123456789012.dkr.ecr.eu-west-1.amazonaws.com/cluster/myapp:v2-22-00&lt;BR&gt;&lt;b&gt;imageDigest&lt;/b&gt;: sha256:5562sfsf60a6d1aaed5c2bb227d3d4ec14c755bdb446349b&lt;BR&gt;&lt;b&gt;runtimeId&lt;/b&gt;: 56832234bec86b30201dbdc94-11149226&lt;BR&gt;&lt;b&gt;lastStatus&lt;/b&gt;: RUNNING&lt;BR&gt;&lt;b&gt;healthStatus&lt;/b&gt;: UNKNOWN&lt;BR&gt;&lt;b&gt;cpu&lt;/b&gt;: 512&lt;BR&gt;&lt;b&gt;memory&lt;/b&gt;: 1024" style="sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image=img/lib/mscae/Docker.svg;labelBackgroundColor=none;" parent="1" vertex="1">
<mxGeometry width="50" height="41" as="geometry"/>
</mxCell>
</root>
Expand Down
Binary file modified docs/docs/onprem-components/output/jpg/docker.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 16 additions & 4 deletions landscape.drawio
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@
<mxCell id="vertex:Build Details Landscape:list" value="&lt;b&gt;Build Details Landscape&lt;/b&gt;" style="swimlane;fontStyle=0;childLayout=stackLayout;horizontal=1;startSize=30;horizontalStack=0;resizeParent=1;resizeParentMax=0;resizeLast=0;collapsible=1;marginBottom=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
<mxGeometry width="300" height="150" as="geometry" y="-80"/>
</mxCell>
<mxCell id="vertex:Build Details Landscape:row:0" value="Build Time: 2023-09-17 14:47:39" style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;spacingLeft=4;spacingRight=4;overflow=hidden;portConstraint=eastwest;rotatable=0;whiteSpace=wrap;html=1;" parent="vertex:Build Details Landscape:list" vertex="1">
<mxCell id="vertex:Build Details Landscape:row:0" value="Build Time: 2024-01-07 14:31:40" style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;spacingLeft=4;spacingRight=4;overflow=hidden;portConstraint=eastwest;rotatable=0;whiteSpace=wrap;html=1;" parent="vertex:Build Details Landscape:list" vertex="1">
<mxGeometry width="300" height="30" y="30" as="geometry"/>
</mxCell>
<mxCell id="vertex:Build Details Landscape:row:1" value="MultiCloud-Diagrams version: 0.3.13" style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;spacingLeft=4;spacingRight=4;overflow=hidden;portConstraint=eastwest;rotatable=0;whiteSpace=wrap;html=1;" parent="vertex:Build Details Landscape:list" vertex="1">
<mxCell id="vertex:Build Details Landscape:row:1" value="MultiCloud-Diagrams version: 0.3.18" style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;spacingLeft=4;spacingRight=4;overflow=hidden;portConstraint=eastwest;rotatable=0;whiteSpace=wrap;html=1;" parent="vertex:Build Details Landscape:list" vertex="1">
<mxGeometry width="300" height="30" y="60" as="geometry"/>
</mxCell>
<mxCell id="vertex:Build Details Landscape:row:2" value="Supported nodes: 18" style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;spacingLeft=4;spacingRight=4;overflow=hidden;portConstraint=eastwest;rotatable=0;whiteSpace=wrap;html=1;" parent="vertex:Build Details Landscape:list" vertex="1">
<mxCell id="vertex:Build Details Landscape:row:2" value="Supported nodes: 22" style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;spacingLeft=4;spacingRight=4;overflow=hidden;portConstraint=eastwest;rotatable=0;whiteSpace=wrap;html=1;" parent="vertex:Build Details Landscape:list" vertex="1">
<mxGeometry width="300" height="30" y="90" as="geometry"/>
</mxCell>
<mxCell id="vertex:Build Details Landscape:row:3" value="HASH: d1945b6e411a12f3" style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;spacingLeft=4;spacingRight=4;overflow=hidden;portConstraint=eastwest;rotatable=0;whiteSpace=wrap;html=1;" parent="vertex:Build Details Landscape:list" vertex="1">
<mxCell id="vertex:Build Details Landscape:row:3" value="HASH: 28495142cc2803a0" style="text;strokeColor=none;fillColor=none;align=left;verticalAlign=middle;spacingLeft=4;spacingRight=4;overflow=hidden;portConstraint=eastwest;rotatable=0;whiteSpace=wrap;html=1;" parent="vertex:Build Details Landscape:list" vertex="1">
<mxGeometry width="300" height="30" y="120" as="geometry"/>
</mxCell>
<mxCell id="vertex:dynamo:arn:aws:dynamodb:eu-west-1:123456789012:table/prod-dynamo-table" value="&lt;b&gt;Name&lt;/b&gt;: prod-dynamo-table&lt;BR&gt;&lt;b&gt;ARN&lt;/b&gt;: arn:aws:dynamodb:eu-west-1:123456789012:table/prod-dynamo-table&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;DeletionProtectionEnabled&lt;/b&gt;: True&lt;BR&gt;&lt;b&gt;ItemCount&lt;/b&gt;: 900&lt;BR&gt;&lt;b&gt;TableSizeBytes&lt;/b&gt;: 123" style="outlineConnect=0;dashed=0;verticalLabelPosition=bottom;verticalAlign=top;align=left;html=1;shape=mxgraph.aws3.dynamo_db;fillColor=#2E73B8;gradientColor=none;" parent="1" vertex="1">
Expand Down Expand Up @@ -73,6 +73,18 @@
<mxCell id="vertex:certificate_manager:arn:aws:acm:us-west-1:123456789012:certificate/cd2e" value="&lt;b&gt;Name&lt;/b&gt;: Client Certificate&lt;BR&gt;&lt;b&gt;ARN&lt;/b&gt;: arn:aws:acm:us-west-1:123456789012:certificate/cd2e&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;ARN&lt;/b&gt;: arn:aws:acm:us-west-1:123456789012:certificate/cd2e&lt;BR&gt;&lt;b&gt;Domain&lt;/b&gt;: client1.domain.tld&lt;BR&gt;&lt;b&gt;Type&lt;/b&gt;: Imported&lt;BR&gt;&lt;b&gt;Public Key info&lt;/b&gt;: RSA 2048&lt;BR&gt;&lt;b&gt;Signature algorithm&lt;/b&gt;: SHA-256 with RSA" style="sketch=0;outlineConnect=0;fontColor=#232F3E;gradientColor=none;fillColor=#3F8624;strokeColor=none;dashed=0;verticalLabelPosition=bottom;verticalAlign=top;align=left;html=1;fontSize=12;fontStyle=0;aspect=fixed;pointerEvents=1;shape=mxgraph.aws4.certificate_manager;" parent="1" vertex="1">
<mxGeometry width="59" height="78" as="geometry" x="1570" y="540"/>
</mxCell>
<mxCell id="vertex:ecs_task:arn:aws:ecs:eu-west-1:123456789012:task/fargate-cluster/562320f29dbdc94" value="&lt;b&gt;Name&lt;/b&gt;: arn:aws:ecs:eu-west-1:123456789012:task/fargate-cluster/562320f29dbdc94&lt;BR&gt;&lt;b&gt;ARN&lt;/b&gt;: arn:aws:ecs:eu-west-1:123456789012:task/fargate-cluster/562320f29dbdc94&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;ecs.cpu-architecture&lt;/b&gt;: x86_64&lt;BR&gt;&lt;b&gt;availabilityZone&lt;/b&gt;: eu-west-1a&lt;BR&gt;&lt;b&gt;connectivity&lt;/b&gt;: CONNECTED&lt;BR&gt;&lt;b&gt;cpu&lt;/b&gt;: 512&lt;BR&gt;&lt;b&gt;memory&lt;/b&gt;: 2048&lt;BR&gt;&lt;b&gt;platformVersion&lt;/b&gt;: 1.4.0&lt;BR&gt;&lt;b&gt;platformFamily&lt;/b&gt;: Linux&lt;BR&gt;&lt;b&gt;version&lt;/b&gt;: 5&lt;BR&gt;&lt;b&gt;ephemeralStorage_sizeInGiB&lt;/b&gt;: 20" style="sketch=0;outlineConnect=0;fontColor=#232F3E;gradientColor=none;fillColor=#D45B07;strokeColor=none;dashed=0;verticalLabelPosition=bottom;verticalAlign=top;align=left;html=1;fontSize=12;fontStyle=0;aspect=fixed;pointerEvents=1;shape=mxgraph.aws4.ecs_task;" parent="1" vertex="1">
<mxGeometry width="37" height="48" as="geometry" x="2090.5" y="192"/>
</mxCell>
<mxCell id="vertex:ecs_service:arn:aws:ecs:us-west-1:123456789012:service/fargate-cluster/service-fg-svc" value="&lt;b&gt;Name&lt;/b&gt;: Nginx_Service&lt;BR&gt;&lt;b&gt;ARN&lt;/b&gt;: arn:aws:ecs:us-west-1:123456789012:service/fargate-cluster/service-fg-svc&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;serviceName&lt;/b&gt;: service-fg-svc&lt;BR&gt;&lt;b&gt;clusterArn&lt;/b&gt;: arn:aws:ecs:eu-west-1:123456789012:cluster/rules-dev-fargate-cluster&lt;BR&gt;&lt;b&gt;serviceRegistries&lt;/b&gt;: arn:aws:servicediscovery:eu-west-1:123456789012:service/srv-t&lt;BR&gt;&lt;b&gt;status&lt;/b&gt;: ACTIVE&lt;BR&gt;&lt;b&gt;desiredCount&lt;/b&gt;: 1&lt;BR&gt;&lt;b&gt;runningCount&lt;/b&gt;: 1&lt;BR&gt;&lt;b&gt;pendingCount&lt;/b&gt;: 0&lt;BR&gt;&lt;b&gt;launchType&lt;/b&gt;: FARGATE&lt;BR&gt;&lt;b&gt;platformVersion&lt;/b&gt;: LATEST&lt;BR&gt;&lt;b&gt;platformFamily&lt;/b&gt;: Linux&lt;BR&gt;&lt;b&gt;taskDefinition&lt;/b&gt;: arn:aws:ecs:eu-west-1:123456789012:task-definition/service-fg-task:15" style="sketch=0;outlineConnect=0;fontColor=#232F3E;gradientColor=none;fillColor=#D45B07;strokeColor=none;dashed=0;verticalLabelPosition=bottom;verticalAlign=top;align=left;html=1;fontSize=12;fontStyle=0;aspect=fixed;pointerEvents=1;shape=mxgraph.aws4.ecs_service;" parent="1" vertex="1">
<mxGeometry width="39" height="48" as="geometry" x="2090.5" y="450"/>
</mxCell>
<mxCell id="vertex:ecs:arn:aws:ecs:eu-west-1:12345689012:cluster/fargate-cluster" value="&lt;b&gt;Name&lt;/b&gt;: Prod-cluster&lt;BR&gt;&lt;b&gt;ARN&lt;/b&gt;: arn:aws:ecs:eu-west-1:12345689012:cluster/fargate-cluster&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;runningTasksCount&lt;/b&gt;: 50&lt;BR&gt;&lt;b&gt;pendingTasksCount&lt;/b&gt;: 0&lt;BR&gt;&lt;b&gt;activeServicesCount&lt;/b&gt;: 50&lt;BR&gt;&lt;b&gt;status&lt;/b&gt;: ACTIVE" style="outlineConnect=0;fontColor=#232F3E;gradientColor=#F78E04;gradientDirection=north;fillColor=#D05C17;strokeColor=#ffffff;dashed=0;verticalLabelPosition=bottom;verticalAlign=top;align=left;html=1;fontSize=12;fontStyle=0;aspect=fixed;shape=mxgraph.aws4.resourceIcon;resIcon=mxgraph.aws4.ecs;" parent="1" vertex="1">
<mxGeometry width="78" height="78" as="geometry" x="2080" y="-50"/>
</mxCell>
<mxCell id="vertex:docker:arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123" value="&lt;b&gt;Name&lt;/b&gt;: docker&lt;BR&gt;&lt;b&gt;ID&lt;/b&gt;: arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123&lt;BR&gt;-----------&lt;BR&gt;&lt;b&gt;name&lt;/b&gt;: my-app&lt;BR&gt;&lt;b&gt;image&lt;/b&gt;: 123456789012.dkr.ecr.eu-west-1.amazonaws.com/cluster/myapp:v2-22-00&lt;BR&gt;&lt;b&gt;imageDigest&lt;/b&gt;: sha256:5562sfsf60a6d1aaed5c2bb227d3d4ec14c755bdb446349b&lt;BR&gt;&lt;b&gt;runtimeId&lt;/b&gt;: 56832234bec86b30201dbdc94-11149226&lt;BR&gt;&lt;b&gt;lastStatus&lt;/b&gt;: RUNNING&lt;BR&gt;&lt;b&gt;healthStatus&lt;/b&gt;: UNKNOWN&lt;BR&gt;&lt;b&gt;cpu&lt;/b&gt;: 512&lt;BR&gt;&lt;b&gt;memory&lt;/b&gt;: 1024" style="sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image=img/lib/mscae/Docker.svg;labelBackgroundColor=none;" parent="1" vertex="1">
<mxGeometry width="50" height="41" as="geometry" x="44" y="760"/>
</mxCell>
</root>
</mxGraphModel>
</diagram>
Expand Down
Binary file modified landscape.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion multicloud_diagrams/providers/onprem.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"desc": "MQ Broker"
},
"docker": {
"style": "sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image=img/lib/mscae/Docker.svg;",
"style": "sketch=0;aspect=fixed;html=1;points=[];align=left;image;fontSize=12;image=img/lib/mscae/Docker.svg;labelBackgroundColor=none;",
"width": "50",
"height": "41",
"version": "0.3.19",
Expand Down
68 changes: 68 additions & 0 deletions samples/landscape.json
Original file line number Diff line number Diff line change
Expand Up @@ -199,5 +199,73 @@
"Signature algorithm": "SHA-256 with RSA"
}
}
},
{
"resource_type": "ecs_task",
"data": {
"arn": "arn:aws:ecs:eu-west-1:123456789012:task/fargate-cluster/562320f29dbdc94",
"name": "arn:aws:ecs:eu-west-1:123456789012:task/fargate-cluster/562320f29dbdc94",
"metadata": {
"ecs.cpu-architecture": "x86_64",
"availabilityZone": "eu-west-1a",
"connectivity": "CONNECTED",
"cpu": "512",
"memory": "2048",
"platformVersion": "1.4.0",
"platformFamily": "Linux",
"version": 5,
"ephemeralStorage_sizeInGiB": 20
}
}
},
{
"resource_type": "ecs_service",
"data": {
"arn": "arn:aws:ecs:us-west-1:123456789012:service/fargate-cluster/service-fg-svc",
"name": "Nginx_Service",
"metadata": {
"serviceName": "service-fg-svc",
"clusterArn": "arn:aws:ecs:eu-west-1:123456789012:cluster/rules-dev-fargate-cluster",
"serviceRegistries": "arn:aws:servicediscovery:eu-west-1:123456789012:service/srv-t",
"status": "ACTIVE",
"desiredCount": 1,
"runningCount": 1,
"pendingCount": 0,
"launchType": "FARGATE",
"platformVersion": "LATEST",
"platformFamily": "Linux",
"taskDefinition": "arn:aws:ecs:eu-west-1:123456789012:task-definition/service-fg-task:15"
}
}
},
{
"resource_type": "ecs",
"data": {
"arn": "arn:aws:ecs:eu-west-1:12345689012:cluster/fargate-cluster",
"name": "Prod-cluster",
"metadata": {
"runningTasksCount": 50,
"pendingTasksCount": 0,
"activeServicesCount": 50,
"status": "ACTIVE"
}
}
},
{
"resource_type": "docker",
"data": {
"arn": "arn:aws:ecs:eu-west-1:123456789012:container/cluster/777/123",
"name": "docker",
"metadata": {
"name": "my-app",
"image": "123456789012.dkr.ecr.eu-west-1.amazonaws.com/cluster/myapp:v2-22-00",
"imageDigest": "sha256:5562sfsf60a6d1aaed5c2bb227d3d4ec14c755bdb446349b",
"runtimeId": "56832234bec86b30201dbdc94-11149226",
"lastStatus": "RUNNING",
"healthStatus": "UNKNOWN",
"cpu": "512",
"memory": "1024"
}
}
}
]

0 comments on commit 9f32c7f

Please sign in to comment.