-
Notifications
You must be signed in to change notification settings - Fork 0
/
coordinator.go
745 lines (616 loc) · 15.4 KB
/
coordinator.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
package index
import (
"context"
"encoding/json"
"errors"
"fmt"
"log/slog"
"math/rand"
"sync"
"sync/atomic"
"time"
"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgconn"
"github.com/jackc/pgx/v5/pgxpool"
"github.com/lucasepe/codename"
"github.com/opensearch-project/opensearch-go/v2"
"github.com/ttab/elephant-api/repository"
"github.com/ttab/elephant-index/postgres"
"github.com/ttab/elephantine"
"github.com/ttab/elephantine/pg"
"golang.org/x/sync/errgroup"
)
const IndexerStopTimeout = 10 * time.Second
type OpenSearchClientFunc func(
ctx context.Context, cluster string,
) (*opensearch.Client, error)
type CoordinatorOptions struct {
Logger *slog.Logger
Metrics *Metrics
Documents repository.Documents
ClientGetter OpenSearchClientFunc
Validator ValidatorSource
DefaultLanguage string
}
type Coordinator struct {
logger *slog.Logger
opt CoordinatorOptions
nameRng *rand.Rand
db *pgxpool.Pool
q *postgres.Queries
changes chan Notification
startCount int32
activeMut sync.RWMutex
activeClient *opensearch.Client
activeSet string
indexers map[string]*Indexer
indexerCtx context.Context
indexerGroup *errgroup.Group
stopOnce sync.Once
stop chan struct{}
stopped chan struct{}
}
func NewCoordinator(
db *pgxpool.Pool, opt CoordinatorOptions,
) (*Coordinator, error) {
rng, err := codename.DefaultRNG()
if err != nil {
return nil, fmt.Errorf("initialise name RNG: %w", err)
}
logger := opt.Logger
if logger == nil {
logger = slog.Default()
}
indexGrp, gCtx := errgroup.WithContext(context.Background())
c := Coordinator{
logger: logger,
db: db,
q: postgres.New(db),
opt: opt,
nameRng: rng,
changes: make(chan Notification),
indexers: make(map[string]*Indexer),
indexerCtx: gCtx,
indexerGroup: indexGrp,
stop: make(chan struct{}),
stopped: make(chan struct{}),
}
return &c, nil
}
// GetActiveIndex the name of the currently active index set, and an OpenSearch
// client that can be used to access it.
func (c *Coordinator) GetActiveIndex() (*opensearch.Client, string) {
c.activeMut.RLock()
defer c.activeMut.RUnlock()
return c.activeClient, c.activeSet
}
// Run the coordinator. A coordinator can only run once.
func (c *Coordinator) Run(ctx context.Context) error {
if c.askedToStop() {
return errors.New("coordinator has been stopped")
}
count := atomic.AddInt32(&c.startCount, 1)
if count > 1 {
return errors.New("already started")
}
go c.cleanupLoop(ctx)
defer close(c.stopped)
var errs []error
err := c.run(ctx)
if err != nil {
c.stopOnce.Do(func() {
close(c.stop)
})
c.logger.ErrorContext(ctx, "failed to run coordinator",
elephantine.LogKeyError, err)
errs = append(errs, err)
}
err = c.finalise()
if err != nil {
errs = append(errs,
fmt.Errorf("post-stop cleanup: %w", err))
}
if len(errs) > 0 {
return errors.Join(errs...)
}
return nil
}
func (c *Coordinator) run(ctx context.Context) error {
eg, ctx := errgroup.WithContext(ctx)
subscribed := make(chan struct{})
eg.Go(func() error {
return c.runListener(ctx, subscribed)
})
eg.Go(func() error {
return c.runEventloop(ctx, subscribed)
})
err := eg.Wait()
if err != nil {
return fmt.Errorf("run listener and eventloop: %w", err)
}
return nil
}
func (c *Coordinator) finalise() error {
// Give an extra 30% on top of the index stop timeout.
indexerDeadline := IndexerStopTimeout / 100 * 130
indexersStopped := make(chan struct{})
go func() {
_ = c.indexerGroup.Wait()
close(indexersStopped)
}()
select {
case <-time.After(indexerDeadline):
return fmt.Errorf("indexers failed to stop in time")
case <-indexersStopped:
return nil
}
}
type NotifyChannel string
const (
NotifyIndexStatusChange NotifyChannel = "index_status_change"
)
type Notification struct {
Type NotifyChannel
Name string
}
func (n Notification) Send(ctx context.Context, q *postgres.Queries) error {
data, err := json.Marshal(n)
if err != nil {
return fmt.Errorf("marshal notification: %w", err)
}
err = q.Notify(ctx, postgres.NotifyParams{
Channel: string(n.Type),
Message: string(data),
})
if err != nil {
return fmt.Errorf("send %q notification", n.Type)
}
return nil
}
func (c *Coordinator) runEventloop(
ctx context.Context,
subscribed chan struct{},
) error {
// Wait with setup until we're subscribed to notifications, better to
// load state and get redundant notifications, than miss a notification
// that would affect state.
select {
case <-subscribed:
case <-ctx.Done():
return ctx.Err() //nolint:wrapcheck
}
q := postgres.New(c.db)
sets, err := q.GetIndexSets(ctx)
if err != nil {
return fmt.Errorf("failed to get the current index sets: %w", err)
}
for _, set := range sets {
err = c.setUpdate(ctx, set)
if err != nil {
return fmt.Errorf(
"set up index set %q: %w",
set.Name, err,
)
}
}
for {
select {
case <-ctx.Done():
return ctx.Err() //nolint:wrapcheck
case change := <-c.changes:
err := c.handleChange(ctx, change)
if err != nil {
return err
}
}
}
}
func (c *Coordinator) handleChange(
ctx context.Context, change Notification,
) error {
// Keeping this as a switch to keep exhaustive linting of NotifyChannel.
//
//nolint:gocritic
switch change.Type {
case NotifyIndexStatusChange:
set, err := c.q.GetIndexSet(ctx, change.Name)
if err != nil {
return fmt.Errorf(
"read status of changed index set %q: %w",
change.Name, err,
)
}
err = c.setUpdate(ctx, set)
if err != nil {
return fmt.Errorf(
"update changed index set %q: %w",
change.Name, err,
)
}
}
return nil
}
func (c *Coordinator) setUpdate(ctx context.Context, set postgres.IndexSet) error {
idxr, ok := c.indexers[set.Name]
// The only state changes that are relevant for the indexer
// right now is a change in the enabled state. That might change
// if/when we introduce partial re-index.
switch {
case (set.Enabled && !set.Deleted) && !ok:
i, err := c.startIndexer(ctx, set)
if err != nil {
return fmt.Errorf(
"start indexer %q: %w",
set.Name, err)
}
c.indexers[set.Name] = i
idxr = i
case ok && (!set.Enabled || set.Deleted):
delete(c.indexers, set.Name)
err := idxr.Stop(IndexerStopTimeout)
if err != nil {
return fmt.Errorf(
"stop disabled indexer: %w", err)
}
}
if set.Active {
err := c.ensureActiveClient(set)
if err != nil {
return fmt.Errorf(
"failed to ensure active client %q: %w",
set.Name, err)
}
}
if set.Deleted {
// Spinning off the post-delete cleanup, no reason to block
// waiting for it.
go func() {
ctx := context.WithoutCancel(ctx)
err := pg.WithTX(ctx, c.logger, c.db,
"direct indice delete",
func(tx pgx.Tx) error {
return c.finaliseSetDelete(
ctx, tx, set.Name)
})
if err != nil {
c.logger.Error(
"cleanup of indices failed",
"set_name", set.Name,
elephantine.LogKeyError, err,
)
}
}()
}
return nil
}
func (c *Coordinator) finaliseSetDelete(
ctx context.Context,
tx pgx.Tx,
name string,
) error {
q := postgres.New(tx)
// GetIndexSetForDelete gets the index_set_row with a FOR UPDATE NOWAIT
// so that only one of the index workers will act on the delete.
idx, err := q.GetIndexSetForDelete(ctx, name)
if errors.Is(err, pgx.ErrNoRows) || !idx.Deleted {
return nil
}
client, err := c.opt.ClientGetter(ctx, idx.Cluster.String)
if err != nil {
return fmt.Errorf(
"get client for cluster %q: %w",
idx.Cluster.String, err)
}
cat := client.Cat.Indices
listRes, err := cat(
cat.WithContext(ctx),
cat.WithFormat("json"),
cat.WithIndex(
"documents-"+idx.Name+"-*",
"percolate-"+idx.Name+"-*",
),
)
if err != nil {
return fmt.Errorf("list indices: %w", err)
}
defer elephantine.SafeClose(
c.logger, "indices list", listRes.Body)
var indices []struct {
Index string `json:"index"`
}
dec := json.NewDecoder(listRes.Body)
err = dec.Decode(&indices)
if err != nil {
return fmt.Errorf("decode indices list: %w", err)
}
if len(indices) > 0 {
names := make([]string, len(indices))
for i := range indices {
names[i] = indices[i].Index
}
del := client.Indices.Delete
delRes, err := del(names,
del.WithContext(ctx))
if err != nil {
return fmt.Errorf("delete indices: %w", err)
}
defer elephantine.SafeClose(
c.logger, "indices delete response", delRes.Body)
}
err = q.DeleteIndexSet(ctx, idx.Name)
if err != nil {
return fmt.Errorf("delete index set from database: %w", err)
}
return nil
}
func (c *Coordinator) ensureActiveClient(set postgres.IndexSet) error {
c.activeMut.Lock()
defer c.activeMut.Unlock()
current := c.activeSet
if current == set.Name {
return nil
}
client, err := c.opt.ClientGetter(context.Background(), set.Cluster.String)
if err != nil {
return fmt.Errorf(
"get client for cluster %q: %w",
set.Cluster.String, err)
}
c.activeClient = client
c.activeSet = set.Name
return nil
}
func (c *Coordinator) startIndexer(
ctx context.Context, set postgres.IndexSet,
) (*Indexer, error) {
client, err := c.opt.ClientGetter(ctx, set.Cluster.String)
if err != nil {
return nil, fmt.Errorf(
"get client for cluster %q: %w",
set.Cluster.String, err)
}
i, err := NewIndexer(ctx, IndexerOptions{
Logger: c.logger.With(
"cluster_name", set.Cluster.String,
"indexer_name", set.Name,
),
SetName: set.Name,
Database: c.db,
Client: client,
Documents: c.opt.Documents,
Validator: c.opt.Validator,
Metrics: c.opt.Metrics,
DefaultLanguage: c.opt.DefaultLanguage,
})
if err != nil {
return nil, fmt.Errorf("create indexer: %w", err)
}
c.indexerGroup.Go(func() error {
err := i.Run(c.indexerCtx)
if errors.Is(err, context.Canceled) {
// Don't treat cancel as an error.
return nil
} else if err != nil {
return fmt.Errorf("run indexer for set %q: %w",
set.Name, err)
}
return nil
})
go func() {
select {
case <-c.stop:
_ = i.Stop(IndexerStopTimeout)
case <-i.Stopping():
return
}
}()
return i, nil
}
func (c *Coordinator) runListener(
ctx context.Context,
subscribed chan struct{},
) error {
// We need an actual connection here, as we're giong to hijack it and
// punt it into listen mode.
poolConn, err := c.db.Acquire(ctx)
if err != nil {
return fmt.Errorf("acquire connection from pool: %w", err)
}
conn := poolConn.Hijack()
defer func() {
err := conn.Close(ctx)
if err != nil {
c.logger.ErrorContext(ctx,
"failed to close PG listen connection",
elephantine.LogKeyError, err)
}
}()
notifications := []NotifyChannel{
NotifyIndexStatusChange,
}
for _, channel := range notifications {
ident := pgx.Identifier{string(channel)}
_, err := conn.Exec(ctx, "LISTEN "+ident.Sanitize())
if err != nil {
return fmt.Errorf("failed to start listening to %q: %w",
channel, err)
}
}
close(subscribed)
received := make(chan *pgconn.Notification)
grp, gCtx := errgroup.WithContext(ctx)
grp.Go(func() error {
for {
notification, err := conn.WaitForNotification(gCtx)
if err != nil {
return fmt.Errorf(
"error while waiting for notification: %w", err)
}
received <- notification
}
})
grp.Go(func() error {
for {
var notification *pgconn.Notification
select {
case <-ctx.Done():
return ctx.Err() //nolint:wrapcheck
case notification = <-received:
}
var note Notification
err := json.Unmarshal(
[]byte(notification.Payload), ¬e,
)
if err != nil {
c.logger.Error("invalid notification payload",
elephantine.LogKeyError, err,
"payload", notification.Payload,
)
continue
}
c.changes <- note
}
})
err = grp.Wait()
if err != nil {
return err //nolint:wrapcheck
}
return nil
}
// Convenience function for cases where it's easier than doing a channel select
// on c.stop.
func (c *Coordinator) askedToStop() bool {
select {
case <-c.stop:
return true
default:
return false
}
}
// Stop the coordinator. Blocks until it has stopped or the timeout has been
// reached.
func (c *Coordinator) Stop(timeout time.Duration) {
c.stopOnce.Do(func() {
close(c.stop)
})
select {
case <-time.After(timeout):
case <-c.stopped:
}
}
// Run cleanup on a 12-24-hour interval.
func (c *Coordinator) cleanupLoop(ctx context.Context) {
for {
err := c.cleanup(ctx)
if err != nil {
c.logger.Error("failed to run cleanup",
elephantine.LogKeyError, err)
select {
case <-time.After(10 * time.Minute):
case <-c.stop:
return
}
}
// Wait between 12 and 24 hours.
//nolint: gosec
randomMinutes := time.Duration(rand.Intn(12*60)) * time.Minute
delay := 12*time.Hour + randomMinutes
select {
case <-time.After(delay):
case <-c.stop:
return
}
}
}
// Delete old index sets that have been marked as deleted.
func (c *Coordinator) cleanup(ctx context.Context) error {
//nolint:wrapcheck
return pg.WithTX(ctx, c.logger, c.db, "cleanup", func(tx pgx.Tx) error {
q := postgres.New(tx)
// Get any remaining deleted sets and delete their indices. This
// should have been handled in the setUpdate() handler, but this
// acts as a retry-mechanism.
deleted, err := q.ListDeletedIndexSets(ctx)
if err != nil {
return fmt.Errorf("list deleted index sets: %w", err)
}
for _, name := range deleted {
err := c.finaliseSetDelete(ctx, tx, name)
if err != nil {
return fmt.Errorf(
"delete indices of %q: %w",
name, err,
)
}
}
return nil
})
}
// Ensure that we have a default cluster and index set. Starts with an ACCESS
// EXCLUSIVE lock on the cluster table, so only one instance will be running
// this check at any given time.
func (c *Coordinator) EnsureDefaultIndexSet(
ctx context.Context,
defaultClusterURL string,
clusterAuth ClusterAuth,
) error {
//nolint:wrapcheck
return pg.WithTX(ctx, c.logger, c.db, "ensure-default-indexer", func(tx pgx.Tx) error {
q := postgres.New(tx)
// Completely lock the cluster table while we initialise.
err := q.LockClusters(ctx)
if err != nil {
return fmt.Errorf("lock cluster table: %w", err)
}
clusters, err := q.GetClusters(ctx)
if err != nil {
return fmt.Errorf("list clusters: %w", err)
}
var clusterName string
if len(clusters) > 0 {
// This is not a fresh setup, leave things as is.
return nil
}
clusterName = codename.Generate(c.nameRng, 0)
authData, err := json.Marshal(clusterAuth)
if err != nil {
return fmt.Errorf("marshal cluster auth: %w", err)
}
err = q.AddCluster(ctx, postgres.AddClusterParams{
Name: clusterName,
Url: defaultClusterURL,
Auth: authData,
})
if err != nil {
return fmt.Errorf("create default cluster: %w", err)
}
// Schema 002 and earlier can have null clusters. Phase
// out before going 1.0.
err = q.SetClusterWhereMissing(ctx, clusterName)
if err != nil {
return fmt.Errorf("set default cluster for index sets: %w", err)
}
indexName := codename.Generate(c.nameRng, 0)
// Create a fresh index set.
err = q.CreateIndexSet(ctx, postgres.CreateIndexSetParams{
Name: indexName,
Cluster: clusterName,
Active: true,
Enabled: true,
})
if err != nil {
return fmt.Errorf("create default index set: %w", err)
}
note := Notification{
Type: NotifyIndexStatusChange,
Name: indexName,
}
err = note.Send(ctx, q)
if err != nil {
return fmt.Errorf(
"notify of index set status change: %w",
err)
}
return nil
})
}