Explictly do not support Windows, avoid error codes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttacon
requested changes
Aug 28, 2019
ttacon
reviewed
Aug 29, 2019
| // NewStyle creates a style starting with the current TextStyle | ||
| // as its text style. | ||
| func (t TextStyle) NewStyle() Style { | ||
| return &style{textStyle: t} |
There was a problem hiding this comment.
Forgive me for my lack of Windows knowledge, should this be an empty string as well?
10 tasks
shils
approved these changes
Apr 14, 2021
shils
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows console does not support the same ANSI character codes, so when they are printed out it ends up looking like gibberish characters.
This PR avoids this by simply returning blank strings for the functions. This removes all color syntax for windows builds only.
Explanation for setting up platform conditional builds is here:
https://dave.cheney.net/2013/10/12/how-to-use-conditional-compilation-with-the-go-build-tool
This change is