Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed expressions substitution #155

Merged
merged 2 commits into from Mar 15, 2019
Merged

Conversation

AlexMost
Copy link
Member

Original issue - #153

  • Fixed expressions substitution
  • Fixed expressions regex (computed properties were not supported
  • Added more test cases

Alexander Mostovenko added 2 commits March 15, 2019 12:32
- fixed expressions regex (computed properties were not supported
- added more test cases
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #155 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   96.81%   96.61%   -0.21%     
==========================================
  Files           4        4              
  Lines         471      472       +1     
  Branches       70       70              
==========================================
  Hits          456      456              
- Misses         15       16       +1
Impacted Files Coverage Δ
src/utils.js 92.13% <100%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3632fa8...9217b5f. Read the comment docs.

@AlexMost AlexMost merged commit ad9d877 into master Mar 15, 2019
@AlexMost AlexMost deleted the fix-translations-substitution branch March 15, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant