Skip to content

Commit

Permalink
Merge pull request #26 from tterb/dev
Browse files Browse the repository at this point in the history
Fix #22 Python 3.4 compatibility
  • Loading branch information
tterb committed Oct 13, 2018
2 parents f950d86 + dbc9d9f commit 9d6ce7f
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 6 deletions.
1 change: 1 addition & 0 deletions .travis.yml
@@ -1,5 +1,6 @@
language: python
python:
- "3.4"
- "3.5"
- "3.6"
os:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -31,7 +31,7 @@ Once finished, the resulting MP3 file will be saved to your *Downloads* director
## Getting Started

### Prerequisites
The program only requires that you have Python 3.5+ and [ffmpeg](https://www.ffmpeg.org/) or [libav](https://www.libav.org/) installed. For more information, check out the [additional setup](https://yt2mp3.readthedocs.io/en/latest/additional_setup.html).
The program only requires that you have Python 3.4+ and [ffmpeg](https://www.ffmpeg.org/) or [libav](https://www.libav.org/) installed. For more information, check out the [additional setup](https://yt2mp3.readthedocs.io/en/latest/additional_setup.html).

### Install
You can install the program with the following command:
Expand Down
2 changes: 1 addition & 1 deletion docs/CHANGELOG.md
Expand Up @@ -3,7 +3,7 @@
## Version 1.2.3

* Improved program CLI
<!-- * Added command-line download spinner -->
* Fixed #22 issue with Python 3.4 compatibility
* Modified program to use `youtube-dl`
* Added option to specify album name

Expand Down
1 change: 1 addition & 0 deletions docs/changelog.rst
Expand Up @@ -6,6 +6,7 @@ Version 1.2.3
----------------

* Improved program CLI
* Fixed `#22 <https://github.com/tterb/yt2mp3/issues/22>`_ issue with Python 3.4 compatibility
* Modified program to use `youtube-dl`
* Added option to specify album name

Expand Down
4 changes: 1 addition & 3 deletions setup.py
Expand Up @@ -34,9 +34,7 @@
],
classifiers = [
'Development Status :: 4 - Beta',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3',
'License :: OSI Approved :: MIT License',
'Operating System :: OS Independent'
]
Expand Down
1 change: 0 additions & 1 deletion yt2mp3/util.py
Expand Up @@ -13,7 +13,6 @@
from colorama import init, Fore, Style
from collections import defaultdict
from bs4 import BeautifulSoup
from yt2mp3.song import Song

# Uses the provided data to find a match in iTunes API
def getSongData(data):
Expand Down

0 comments on commit 9d6ce7f

Please sign in to comment.