Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17: Add option to specify album #25

Merged
merged 5 commits into from Oct 10, 2018
Merged

Fix #17: Add option to specify album #25

merged 5 commits into from Oct 10, 2018

Conversation

tterb
Copy link
Owner

@tterb tterb commented Oct 10, 2018

Description

Added a command-line option that prompts the user to specify the target album name.

Motivation and Context

Fixes #17

How Has This Been Tested?

python3 setup.py test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tterb tterb self-assigned this Oct 10, 2018
@tterb tterb merged commit f950d86 into master Oct 10, 2018
@wsc96
Copy link

wsc96 commented Oct 10, 2018

Hi tterb,

I tried this out but received the below:

hostname:yt2mp3 username$ yt2mp3 -c
Track: Fraction Too Much Friction
Artist: Tim Finn
Album: iTunes Live From Windsor Castle
✘ No results found with the keyword Fraction Too Much Friction Tim Finn iTunes Live From Windsor Castle

I get the same result with other tracks using data from iTunes (for track/artist/album info and spelling).

Any ideas?

*** Update - It appears to match the album name but not the album name as it is shown in iTunes. An example is below:

hostname:yt2mp3 username$ yt2mp3 -c
Track: Natural Born Killaz
Artist: Ice Cube
Album: Natural Born Killaz by Ice Cube
✔ Download Complete
♬ Converting to MP3
✔ Done

This matched the Album "Featuring... Ice Cube" but if I specified "Featuring... Ice Cube" within yt2mp3 I got the below error:

✘ No results found with the keyword Natural Born Killaz Ice Cube Featuring... Ice Cube

@wsc96
Copy link

wsc96 commented Oct 11, 2018

I've been looking a bit at the iTunes API and it seems that collectionName doesn't necessarily match the Album Name as displayed in iTunes and this is what tripped me up.

@tterb
Copy link
Owner Author

tterb commented Oct 11, 2018

@wsc96 Thanks for the info, I'll look more into what I can do to ensure that the specified album matches the album name displayed on iTunes. If you're able to find anything else that may be helpful or have any suggestions, feel free to let me know or create an issue with your findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to Select Album - enhancement
2 participants