Refine stats table formatting #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make formatting of values in the stats table a little more consistent: * Use KiB/MiB/GiB for traffic counts, indicating 1024 dividers. * Allow thresholds to use Mbit or Gbit. Add "/s", matching (being removed) bandwidth label. * Format bandwidth like thresholds. (Which includes switching to pure 1000 dividers, allowing a quick comparison with the 1000*1024 based configured value). * Format round trip time like other times; correct "Rount"->"Round".
|
What happens to the Tin tables when using diffserv8? I have a vague sense that I had to conserve in-cell space for the diffserv8 scenario. Can’t test it myself since I’m no longer running the firmware. |
|
This will tend to make the tin cells narrower - it may be adding In my set-up, the table doesn't get any wider by switching from diffserv3 to diffserv8. Each column is a neat |
ttgapers
added a commit
that referenced
this pull request
Jan 9, 2022
- #85 - #86 Thanks @kjbracey & @dave14305
|
Thanks @kjbracey & @dave14305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make formatting of values in the stats table a little more consistent: