Complete existing tests #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneeded jest syntax from last test.
|
@MarcAtrapalo I had no idea anyone would find use for this. I'm really really really happy you are getting value from it though. I will dedicate some time to improving it and sharing it with others. I'll have a read through the pull request tonight. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Thomas,
Thank you for this great koans. I'm using it to train my fellow colleagues in generators and redux-saga, and this is just what I needed, and a great way to learn it.
I have taken the liberty to complete the two tests that were unfinished: The last in
saga-basicsand the one inyield-star. Please tell me if they suit your code, and feel free to incorporate or improve them.Thanks,
Marc.