Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony6 #2

Merged
merged 3 commits into from Dec 3, 2021
Merged

Allow symfony6 #2

merged 3 commits into from Dec 3, 2021

Conversation

77web
Copy link
Contributor

@77web 77web commented Nov 30, 2021

We want to update our project using this bundle to Symfony6.
So please allow Symfony6 馃

@77web
Copy link
Contributor Author

77web commented Nov 30, 2021

in lowest deps CI, Symfony3.4 KernelTestCase does not comply phpunit signature 馃

@77web
Copy link
Contributor Author

77web commented Nov 30, 2021

@ttskch Please review 馃檹

@ttskch
Copy link
Owner

ttskch commented Dec 3, 2021

@77web
Thanks a lot!

I found that symfony/framework-bundle 4.2.3- are not compatible with phpunit8.

And in the first place, unfortunately, this library cannot be tested with Symfony 5.0- and Symfony 5.1+ at the same time because of a BC Breaking in Symfony 5.1+.

So could you please do following?

  • don't remove symfony/framework-bundle from require-dev
  • modify require-dev > symfony/framework-bundle from ^5.2 to ^5.1|^6.0

I don't know why I specified not ^5.1 but ^5.2 originally馃槄

Thanks.

@siketyan
Copy link

siketyan commented Dec 3, 2021

Suggestion:

if (\Symfony\Component\HttpKernel\Kernel::VERSION_ID >= 50100) {
    protected function configureContainer(ContainerConfigurator $c)
    {
        $c->import(__DIR__.'/Resources/config/test.yaml');
    }
) else {
    protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader)
    {
        // I do not care this works
        $loader->load(__DIR__.'/Resources/config/test.yaml');
    }
}

@ttskch
Copy link
Owner

ttskch commented Dec 3, 2021

@siketyan OMG. I'm trying that after this. Thanks!

@ttskch
Copy link
Owner

ttskch commented Dec 3, 2021

@77web Thanks!

@ttskch ttskch merged commit a407f08 into ttskch:master Dec 3, 2021
@77web 77web deleted the allow-symfony6 branch December 3, 2021 02:29
ttskch added a commit that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants