Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] add a variables file, allow modifying the variables used in the scss files #51

Open
WilliamStam opened this issue May 27, 2020 · 2 comments

Comments

@WilliamStam
Copy link

im not a fan of the forcing of using secondary for many of the label colours etc. wouldnt it be better if you included a _variables.scss file similar to how bootstrap does it with !default? that way we can override the defaults with say $select2-theme-bootstrap4-secondary: $gray;

$select2-theme-bootstrap4-input-bg: $input-bg !default;
$select2-theme-bootstrap4-input-border-radius: $input-border-radius !default;
$select2-theme-bootstrap4-input-box-shadow: $input-box-shadow !default;
$select2-theme-bootstrap4-input-transition: $input-transition !default;
$select2-theme-bootstrap4-input-focus-border-color: $input-focus-border-color !default;
$select2-theme-bootstrap4-input-focus-box-shadow: $input-focus-box-shadow !default;
$select2-theme-bootstrap4-input-disabled-bg: $input-disabled-bg !default;


$select2-theme-bootstrap4-secondary: $secondary !default;

should be as easy as finding $ and then just prefixing them with a prefix and setting up a _variables.scss file

@rodrigo-arias
Copy link

Totally in favor of this approach

@tagliala
Copy link
Contributor

tagliala commented Mar 3, 2021

I would like to do this in #67

tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 3, 2021
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 3, 2021
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 3, 2021
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 4, 2021
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 13, 2021
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 14, 2021
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 14, 2021
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants