Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add share screen method #11

Merged
merged 1 commit into from
Jan 6, 2022
Merged

add share screen method #11

merged 1 commit into from
Jan 6, 2022

Conversation

Noth3r
Copy link
Contributor

@Noth3r Noth3r commented Jan 5, 2022

Using package called stream-display to getDisplayMedia that sends screen video feed as ImageData then changed to ImageBitmap so can be decoded with nimiq/qr-scanner

For this PR, I add 2 features

@lc-at lc-at self-requested a review January 5, 2022 15:29
@lc-at
Copy link
Owner

lc-at commented Jan 5, 2022

Nice PR. I will test and review this PR tomorrow.

@lc-at lc-at linked an issue Jan 5, 2022 that may be closed by this pull request
Copy link
Owner

@lc-at lc-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the PR looks quite good to me. I just have a few suggestion on it (see my review comment). What do you think of it?

If you agree, can you wire up the revision? If you can't, I am willing to wire it up.

praesentia/templates/home.html Show resolved Hide resolved
@lc-at lc-at merged commit bb705d9 into lc-at:main Jan 6, 2022
@lc-at
Copy link
Owner

lc-at commented Jan 6, 2022

Merged.

Thanks! I really appreciate it. If you have a lot of spare times, feel free to take a look on the other issues.

lc-at added a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan QR code by "share screen"
2 participants