0.8.0 fails to launch

[0323pin]

Hi,

I was a few days late and pushed 0.7.0 into our repositories today and all was working fine.
Now, I've just built 0.8.0 but I'm getting

Error: No such file or directory (os error 2)
Exception: wthrr exited with 1

That's all.
Reverted to 0.7.0 and it's working. Any clues?
I'm currently building my whole system from source, no pre-compiled binaries and still don't have a web-browser. Besides, I'll be away from Thursday until next Tuesday.

Just an heads-up in case it takes sometime to reply :)

[ttytm]

Hey @0323pin
It's good to get report on such errors. Since I'm limited resource wise it's not always possible for me to spot them. So thanks alot for your report, it really helps to improve the app!

Most probably I missed a clause when checking for the translations that can now be saved to a file.

When I have I free moment I'll investigate later this day else it'll be fixed tomorrow 👍

[0323pin]

Cheers.
The error itself doesn't say much, hopefully it will be easy to spot. Thanks!

EDIT: Needless to say, I'll keep our package at 0.7.0 for now.

[ttytm]

Yes, I definitely need to get the dependencies in Cargo.toml straight.
The way to reproduce this error when building from source is making locales/pure-rust-locales.txt unavailable. Then when asking for the weekly forecast, when this file should get accessed for datetime localization we get the error. I would like to keep it as a build file and save the users from having to fetch it or to have it stored on their machine post build.

[0323pin]

@tobealive I see you have edited your original reply, it differs from the automatic e-mail github sends out.

And can you verify that building is possible when using the full repo?

We do fetch the full repo to build the package. But, then we/I do,

${INSTALL_PROGRAM} ${WRKSRC}/target/release/wthrr \
		${DESTDIR}${PREFIX}/bin

You can find the full package Makefile here, rust dependencies are declared in a separate cargo-depends.mk file which, is called from the Makefile with .include "cargo-depends.mk"

Do you mean I should fetch and install locales/pure-rust-locales.txt somewhere in the root file system? In this case, where should it be located?

I definitely need to get the dependencies in Cargo.toml straight.

Let's try that, else it's possible to fetch it from the build directory and install it as a separate file. I usually do this with, e.g. .desktop files.

[ttytm]

Yes, after realizing the silliness of this mistake, I changed the initial answer to reflect that this definitely needs to be fixed.

Do you mean I should fetch and install locales/pure-rust-locales.txt somewhere in the root file system? In this case, where should it be located?

Nope, that's not wanted.

---

I included it as a constant now which should make sure it's included in the build process. As far as I could check this did the trick.

[0323pin]

I'll see if I can build it before my travel, else next Wed.

Thanks!

[0323pin]

@tobealive I've just built 0.8.2 locally and everything is working fine again, thanks!

Didn't have the time to merge the update yet. Need to get some sleep. I'll try to merge it in the morning, else Tuesday late evening. Closing this now.

[0323pin]

Done, https://mail-index.netbsd.org/pkgsrc-changes/2023/02/23/msg269887.html

[ttytm]

Awesome 💪 thank you 😊!

[0323pin]

@ttytm Long time, no see. Sorry for posting on a closed thread but, I was just wondering if a new release is due anytime soon? 76 commits after latest! Any breaking stuff?

Thanks and regards.

[ttytm]

Hey @0323pin, no worries, good to hear from you!

Yes it's planned. The wasn't happening much in the last time here.
The changes have been mostly small refactoring and dependency updates.
Next thing I'll work on is finishing the fix for #135 then a new version is ripe.

[0323pin]

Nice, thanks!

I'll keep an eye on it. Hopefully, I'll remember to switch MASTER_SITES= ${MASTER_SITE_GITHUB:=tobealive/} to your new github repo 😄

[kevinmatthes]

@ttytm @0323pin

Regarding the question of a new version being published, I created a poll (#248) on my idea to release at least a patch every month in order to benefit from the changes of the latest dependency updates. Maybe we could continue the discussion of the next release's contents there, as well.