Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribes qos is ignored #82

Closed
Suxsem opened this issue Dec 15, 2015 · 2 comments
Closed

subscribes qos is ignored #82

Suxsem opened this issue Dec 15, 2015 · 2 comments

Comments

@Suxsem
Copy link

Suxsem commented Dec 15, 2015

qos is not used in MQTT_Subscribe(MQTT_Client client, char topic, uint8_t qos)

all subscribes are done with qos=0

client->mqtt_state.outbound_message = mqtt_msg_subscribe(&client->mqtt_state.mqtt_connection,
topic, 0,
&client->mqtt_state.pending_msg_id);

must be fixed as soon as possible

@harryd100
Copy link

"must be fixed as soon as possible", this is an Open Source project where people put in a lot of free time to make something free of costs. If you ask nicely, maybe Tuan is willing to fix this for all of us if this is a bug.

@Namphibian
Copy link

Agree with harryd100 here.

Ask nicely or better yet as the code is available why dont you give a
helping hand and fix the code? Help the project out if you are using it. I
have 101 outstanding items on this library but since it is not my full time
job I have to find time to get things done.

Talking of which I need to do a pull request soon I have some mods that
needs to go in but they are all Wifi and REST related.

On Wed, Dec 16, 2015 at 9:43 PM, harryd100 notifications@github.com wrote:

"must be fixed as soon as possible", this is an Open Source project where
people put in a lot of free time to make something free of costs. If you
ask nicely, maybe Tuan is willing to fix this for all of us if this is a
bug.


Reply to this email directly or view it on GitHub
#82 (comment).

@tuanpmt tuanpmt closed this as completed in a08749f Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants