Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template #12

Closed
Tracked by #9
oliver-pham opened this issue Jan 9, 2022 · 2 comments · Fixed by #19
Closed
Tracked by #9

Pull request template #12

oliver-pham opened this issue Jan 9, 2022 · 2 comments · Fixed by #19
Assignees
Labels
difficulty:easy Issue that takes 1 - 3 days documentation Improvements or additions to documentation priority:medium Issue to be done in the current sprint
Projects

Comments

@oliver-pham
Copy link
Collaborator

oliver-pham commented Jan 9, 2022

We should craft a template for every pull request beforehand. This should save us more time on deciding what to write in a PR description.

Some suggestions:

About PR desc we should provide what have been done, which packages have been used and a screenshot (if necessary) - hlavu

The title should describe the area tackled by the PR and what it wants to add to our app. For instance, [WIP] match: Prototype matching algorithm informs that the PR solves an issue in the matching algorithm but it's a work-in-progress. - oliver-pham

The title might need the type as well (eg: feature, bugfix, refactor, ...)
As for the description, we should also include related issues - minhhang107

Resources

@oliver-pham oliver-pham added question Further information is requested priority:medium Issue to be done in the current sprint labels Jan 9, 2022
@oliver-pham oliver-pham mentioned this issue Jan 9, 2022
4 tasks
@tuanthanh2067
Copy link
Owner

tuanthanh2067 commented Jan 9, 2022

Yes, this is a great idea. I can include it in #11 after we all agree on a template.

@minhhang107
Copy link
Collaborator

The title might need the type as well (eg: feature, bugfix, refactor, ...)
As for the description, we should also include related issues

@oliver-pham oliver-pham added this to Backlog in Seeksi via automation Jan 10, 2022
@oliver-pham oliver-pham moved this from Backlog to To Do in Seeksi Jan 10, 2022
@oliver-pham oliver-pham added difficulty:easy Issue that takes 1 - 3 days documentation Improvements or additions to documentation and removed question Further information is requested labels Jan 10, 2022
@oliver-pham oliver-pham moved this from To Do to In progress in Seeksi Jan 12, 2022
@minhhang107 minhhang107 moved this from In progress to Done in Seeksi Jan 14, 2022
@oliver-pham oliver-pham reopened this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:easy Issue that takes 1 - 3 days documentation Improvements or additions to documentation priority:medium Issue to be done in the current sprint
Projects
Seeksi
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants