Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contributing file #11

Merged
merged 2 commits into from
Jan 15, 2022
Merged

add contributing file #11

merged 2 commits into from
Jan 15, 2022

Conversation

tuanthanh2067
Copy link
Owner

Issue #9

This PR will add docs of our contributing convention for our devs!

@vercel
Copy link

vercel bot commented Jan 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/4GmziDg4Q22PgWRmzAj3KUD9cZMS
✅ Preview: https://seeksi-git-issue9-tuanthanh2067.vercel.app

@tuanthanh2067 tuanthanh2067 added the documentation Improvements or additions to documentation label Jan 9, 2022
@oliver-pham oliver-pham linked an issue Jan 10, 2022 that may be closed by this pull request
4 tasks
@tuanthanh2067
Copy link
Owner Author

@oliver-pham .

Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🥇 Go ahead and merge this PR

Edited: Sorry, I meant to approve the latest commit

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥇 Let's merge this one

@tuanthanh2067 tuanthanh2067 merged commit c22a202 into main Jan 15, 2022
@oliver-pham oliver-pham deleted the issue#9 branch January 19, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine Conventions
2 participants