Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: build sign up form #104

Merged
merged 1 commit into from
Jan 31, 2022
Merged

feature: build sign up form #104

merged 1 commit into from
Jan 31, 2022

Conversation

hlavu
Copy link
Collaborator

@hlavu hlavu commented Jan 31, 2022 •
edited
Loading

Related issue

Fixes #30

Type of Change

  • Feat: Change which adds functionality/new feature
  • Fix: Change which fixes an issue
  • Refactor: Change which improves the structure of the code
  • Docs: Change which improves documentation

Description

  • Create sign up form with input fields and field validations
  • Create mutations to send input data to server

Screenshot

image

image

image

image

image

image

Testing

  • UI has been tested
  • Backend not

Note

The title of your PR should follow this format: [Type](area): Title

@vercel
Copy link

vercel bot commented Jan 31, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/8sYRZE3LhGmVyHFmof5cXJZejBmZ
✅ Preview: https://seeksi-git-feature-30-build-sign-up-form-tuanthanh2067.vercel.app

@oliver-pham
Copy link
Collaborator

Excellent work 🥳 , @hlavu ! I'm glad you manage to understand (enough) GraphQL in such a time constraint.

After applying the changes that I recommended, everything should work as expected. POC:
Screen Shot 2022-01-30 at 11 35 11 PM
Screen Shot 2022-01-30 at 11 35 15 PM

minhhang107
minhhang107 requested changes Jan 31, 2022
View reviewed changes
frontend/src/pages/Modal/Signup.js Outdated Show resolved Hide resolved
@hlavu hlavu force-pushed the feature/30-build-sign-up-form branch from c0337fe to 7f3bc0c Compare January 31, 2022 09:52
oliver-pham
oliver-pham requested changes Jan 31, 2022
View reviewed changes
frontend/src/graphql/mutations/Mutations.js Outdated Show resolved Hide resolved
frontend/src/graphql/mutations/Mutations.js Outdated Show resolved Hide resolved
frontend/src/pages/Modal/Signup.js Outdated Show resolved Hide resolved
frontend/src/pages/Modal/Signup.js Outdated Show resolved Hide resolved
minhhang107
minhhang107 requested changes Jan 31, 2022
View reviewed changes
frontend/src/pages/Modal/Signup.js Outdated Show resolved Hide resolved
@hlavu hlavu force-pushed the feature/30-build-sign-up-form branch from 7f3bc0c to 49ccd69 Compare January 31, 2022 17:48
@hlavu hlavu force-pushed the feature/30-build-sign-up-form branch from 49ccd69 to 0e06c62 Compare January 31, 2022 18:03
@minhhang107 minhhang107 self-requested a review January 31, 2022 18:15
@hlavu hlavu merged commit 9b492b4 into main Jan 31, 2022
@hlavu hlavu deleted the feature/30-build-sign-up-form branch January 31, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-pham oliver-pham oliver-pham approved these changes

@minhhang107 minhhang107 minhhang107 approved these changes

@mqnguyen5 mqnguyen5 Awaiting requested review from mqnguyen5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Sign Up Form
3 participants
@hlavu @oliver-pham @minhhang107