Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: send match request #162

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Feature: send match request #162

merged 2 commits into from
Feb 11, 2022

Conversation

tuanthanh2067
Copy link
Owner

Related issue

Fixes #73

Type of Change

  • Feat: Change which adds functionality/new feature
  • Fix: Change which fixes an issue
  • Refactor: Change which improves the structure of the code
  • Docs: Change which improves documentation

Description

This PR adds a new PotentialMatch service in graphql and update pairID field in mongoose schema.

@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/FoNy3UYkZ6HmHL81bs8r9RPiNEHD
✅ Preview: https://seeksi-git-feature-73-send-match-request-tuanthanh2067.vercel.app

oliver-pham
oliver-pham approved these changes Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯 ! We can probably create a separate issue for handling a match (when two users "like" each other). Feel free to merge!

@tuanthanh2067 tuanthanh2067 merged commit 178d988 into main Feb 11, 2022
@tuanthanh2067 tuanthanh2067 deleted the feature/73-send-match-request branch February 11, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-pham oliver-pham oliver-pham approved these changes

@dtnguyen22 dtnguyen22 Awaiting requested review from dtnguyen22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send match request to another User
2 participants
@tuanthanh2067 @oliver-pham