Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add query to get potential partners #233

Merged
merged 3 commits into from
Feb 27, 2022

Conversation

minhhang107
Copy link
Collaborator

@minhhang107 minhhang107 commented Feb 24, 2022

Related issue

Fixes #134

Type of Change

  • Feat: Change which adds functionality/new feature
  • Fix: Change which fixes an issue
  • Refactor: Change which improves the structure of the code
  • Docs: Change which improves documentation

Description

  • add query
  • remove hardcode
  • add user profile link to profile card
  • fix styling

Demo

match.mp4

Testing

Has this pull request been tested? yes

Please describe shortly how you tested it: test with BE team

Note

The title of your PR should follow this format: [Type](area): Title

* add query
* remove hardcode
* add user profile link to profile card
* fix styling
@vercel
Copy link

vercel bot commented Feb 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/Gjdh7spk4B313WmRDiShijVJhhvt
✅ Preview: https://seeksi-git-feature-134-add-potential-partn-c9ac67-tuanthanh2067.vercel.app

Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query works great! However, I think there's an issue with displaying the information
Screen Shot 2022-02-26 at 12 32 14 PM

@minhhang107
Copy link
Collaborator Author

@oliver-pham resolved
fixed

Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯 Thanks a lot!

capoo

@minhhang107 minhhang107 merged commit d390bea into main Feb 27, 2022
@minhhang107 minhhang107 deleted the feature/134-add-potential-partners-query branch February 27, 2022 00:03
mqnguyen5 pushed a commit that referenced this pull request Mar 2, 2022
* feature: add query to get potential partners
mqnguyen5 added a commit that referenced this pull request Mar 3, 2022
* feature: add query to get potential partners (#233)

* feature: add query to get potential partners

* feature/232-connect-chatpartner-to-chatwindow
	* added state management to get selected (active) room ID
	* added event handling to retrieve selected room in chatPartner
	* adjusted the initial content rendered in chatWindow
	* fixed minor bugs related to child components don't have a "key" prop
	* added text indicating that there is no chat window opened

Co-authored-by: Minh Hang Nguyen (Jenny) <55411709+minhhang107@users.noreply.github.com>
Co-authored-by: Luke Nguyen <lukenguyen.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add client query for potential partners
2 participants