Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(database): configure mongo database #78

Merged
merged 9 commits into from
Jan 25, 2022

Conversation

tuanthanh2067
Copy link
Owner

Related issue

Fixes #77

Type of Change

  • Feat: Change which adds functionality/new feature
  • Fix: Change which fixes an issue
  • Refactor: Change which improves the structure of the code
  • Docs: Change which improves documentation

Description

Configure mongo database.

@vercel
Copy link

vercel bot commented Jan 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tuanthanh2067/seeksi/D8MKEUTjVSjdot771ztspLAAWzHm
✅ Preview: https://seeksi-git-feature-77-configure-mongo-db-tuanthanh2067.vercel.app

Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! Let's merge this 🍿 .

@oliver-pham
Copy link
Collaborator

Overall, excellent work, @tuanthanh2067! I think for pairId, type should be ObjectId, since we are using MongoDB auto-generated unique identifiers.

@tuanthanh2067
Copy link
Owner Author

@oliver-pham I don't think it's necessary but I don't know why hehe.

@oliver-pham
Copy link
Collaborator

We'll just focus on User for now. Other schemas will be reviewed and fixed when we tackle the issues related to them.

backend/src/schemas/share/Location.js Outdated Show resolved Hide resolved
backend/src/schemas/User/Preference.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@oliver-pham oliver-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mergeee 🍿

@tuanthanh2067 tuanthanh2067 merged commit 915e230 into main Jan 25, 2022
@oliver-pham oliver-pham deleted the feature/77-configure-mongo-db branch February 4, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mongo database
3 participants