Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more flexible 0% step keyframes fix #9

Closed
wants to merge 1 commit into from
Closed

more flexible 0% step keyframes fix #9

wants to merge 1 commit into from

Conversation

nightmode
Copy link

Thank you so much for making this port. Loving it!

I was doing some testing and found that @Keyframes with grouped selector steps like '0%,100%' were coming out as '0,100%'.

So, this pull request will happily deal with that common scenario and it even works for odd edge cases like...

@Keyframes name{0,to,from{...}to{...}};
@Keyframes name{100%,to,from{...}to{...}};
@Keyframes name{100%,0,to{...}to{...}};
@Keyframes name{from,0,to{...}to{...}};
@Keyframes name{from,to,0{...}to{...}};
@Keyframes name{from,to{...}to{...}};

Please let me know if you see anything you want to tweaked or if there are any tests I can help with. Very happy to help. :D

PS - I had tried most of the popular PHP minifiers out there and they all had serious problems. I was dreading the prospecting of having to code my own from scratch so you can imagine how happy I was to discover your code! Thank you so much. ^_^

Supports adding a % to 0 percent steps in grouped keyframe selectors
like '0, 50%' and edge cases like '10%, to, 0'.
@nightmode
Copy link
Author

Happy to help with any additional testing you want before a merge. Well, assuming you like the code which I hope you do. :D

@tubalmartin
Copy link
Owner

Done! I had to modify your solution since it didn't pass all my tests. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants