Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add checkbox for controlling whether queue line tvs are built #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarkOtzen
Copy link

A feature for excluding queue line TVs from the automatic behaviour is something I wanted, so I made a PR.
A few reasons I chose:

  • They're expensive
  • They don't necessarily provide value
  • They are ugly

Since this is my first time touching both this language and this menuing system, I have a few things I think might make more sense to achieve this functionality;

  • I don't know how the feature should be worded exactly
  • It would be cleaner if the checkbox was tied to the TV dropdown as to indicate "the disabling of" (or a "unusable" TV fake-type)
  • I'm slightly performance aware of checking for TV building status upon each "action.execute" -> "footpathplace" action; would determining that we're on a queue line earlier, and as such exiting sooner, be a more reasonable solution?

Any feedback would be appreciated.

@MarkOtzen MarkOtzen requested a review from tubbo as a code owner August 20, 2023 17:27
@RundesBalli
Copy link

Especially in the early game, they are often still too expensive. That's why this is a good idea in my opinion. I think it's great.

@MarkOtzen
Copy link
Author

This PR has some overlap with #72 so I'm not quite sure how to proceed. That one has more features and they seem to overshadow this.

I think some UI work could be needed to achieve the functionality of the other PR but... neater.

@tubbo tubbo added the enhancement New feature or request label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants