Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe and join buttons overlap #10

Closed
mattkdoggie opened this issue Dec 1, 2022 · 3 comments
Closed

Subscribe and join buttons overlap #10

mattkdoggie opened this issue Dec 1, 2022 · 3 comments

Comments

@mattkdoggie
Copy link

The subscribe and join buttons overlap when there is not enough space horizontally. It also cuts off the channel info as well.

Example without join button -
Screenshot 2022-11-30 at 7 39 02 PM

Example with join button -
Screenshot 2022-11-30 at 7 39 52 PM

bbilly1 added a commit that referenced this issue Dec 2, 2022
@bbilly1
Copy link
Member

bbilly1 commented Dec 2, 2022

I think I got this to behave nicer now. The channel name cut off is a YouTube thing. That will happen a bit sooner now with the additional button taking up space than it otherwise would. But I don't think we can avoid that. In any case, v0.1.1 will be out once it passes validations.

@bbilly1 bbilly1 closed this as completed Dec 2, 2022
@mattkdoggie
Copy link
Author

mattkdoggie commented Dec 2, 2022

Looks better but I'm now getting the like button to overlap in some situations.
Example -
Screenshot 2022-12-02 at 7 46 03 AM

This is only happening in a very narrow width.

@bbilly1
Copy link
Member

bbilly1 commented Dec 2, 2022

Sometimes it needs a page refresh for the other youtube buttons to realize there isn't enough space anymore, sometimes it doesn't trigger on window resize. If you want to keep tinkering with it, please do. We can always also finetuning it as we go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants