New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix port parsing logic #11

Merged

bbilly1 merged 1 commit into tubearchivist:master from bakkot:protocol-has-colon

Dec 2, 2022

Contributor

bakkot commented Dec 2, 2022

let url = new URL('https://example.com:443');
console.log(url.port); // empty string, because it's the default for the protocol
console.log(url.protocol); // 'https:' - note the colon, which was missing in the logic below


          fix port parsing logic

18bfa28

bbilly1 merged commit 52b65bf into tubearchivist:master

bakkot deleted the protocol-has-colon branch

December 3, 2022 02:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment