Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total videos archived count is off if playlist contains duplicated videos #154

Closed
nonmaterialistically opened this issue Jan 18, 2022 · 3 comments
Labels
wontfix This will not be worked on

Comments

@nonmaterialistically
Copy link

Issue

When a playlist contains the same video multiple times, it only gets counted once againts the total videos archived count.

How to reproduce

  1. Create a playlist and add a video
  2. Add a different video, twice
  3. Download the playlist with 3 items (2 videos appear on the download queue)
  4. The playlist now says: "Total Videos archived: 2/3"

For any given video, it should probably be counted how many times it appears in a playlist.

@bbilly1
Copy link
Member

bbilly1 commented Jan 22, 2022

I think a good solution here would be to just not index duplicates in the first place. With the downside that the total videos in the playlist of Tube Archivist won't match with the total on YouTube...

@bbilly1 bbilly1 added the enhancement New feature or request label Jan 22, 2022
@nonmaterialistically
Copy link
Author

nonmaterialistically commented Jan 22, 2022

The latest yt-dlp release includes a new playlist_count field in the playlists .info.json. Maybe we could display that in the UI as the total videos on YouTube, and if they differ then display a "unique videos" which is our TA total.

@bbilly1 bbilly1 added the good first issue Good for newcomers label Mar 27, 2023
@bbilly1 bbilly1 added wontfix This will not be worked on and removed enhancement New feature or request good first issue Good for newcomers labels Jul 27, 2023
@bbilly1
Copy link
Member

bbilly1 commented Jul 27, 2023

Closing old issues. Nobody wanted to take this on, as this is working in TA without any problems and mostly cosmetic. If you feel strongly about that, feel free to implement it.

@bbilly1 bbilly1 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants